From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Daniel Mack <zonque@gmail•com>, f.fainelli@gmail•com
Cc: netdev@vger•kernel.org, davem@davemloft•net, mugunthanvnm@ti•com,
ujhelyi.m@gmail•com
Subject: Re: [PATCH 1/3] net: of_mdio: factor out code to parse a phy's 'reg' property
Date: Sun, 11 May 2014 00:29:02 +0400 [thread overview]
Message-ID: <536E8C0E.3040407@cogentembedded.com> (raw)
In-Reply-To: <1399739875-16434-2-git-send-email-zonque@gmail.com>
Hello.
On 05/10/2014 08:37 PM, Daniel Mack wrote:
> Factor out some logic into of_mdio_parse_addr() so it can be reused
> later.
> Signed-off-by: Daniel Mack <zonque@gmail•com>
> ---
> drivers/of/of_mdio.c | 37 +++++++++++++++++++++++++------------
> 1 file changed, 25 insertions(+), 12 deletions(-)
> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 9a95831..171f9d5 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -114,6 +114,29 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, struct device_node *chi
> return 0;
> }
>
> +static int of_mdio_parse_addr(struct device *dev, const struct device_node *np)
> +{
> + const __be32 *paddr;
> + u32 addr;
> + int len;
> +
> + /* A PHY must have a reg property in the range [0-31] */
> + paddr = of_get_property(np, "reg", &len);
> + if (!paddr || len < sizeof(*paddr)) {
> + dev_err(dev, "%s has invalid PHY address\n", np->full_name);
> + return -EINVAL;
> + }
> +
> + addr = be32_to_cpup(paddr);
Why not just use of_property_read_u32() instead of the above? At least
that's a material for a follow-up patch...
> + if (addr >= PHY_MAX_ADDR) {
> + dev_err(dev, "%s PHY address %i is too large\n",
> + np->full_name, addr);
> + return -EINVAL;
> + }
> +
> + return addr;
> +}
> +
> /**
> * of_mdiobus_register - Register mii_bus and create PHYs from the device tree
> * @mdio: pointer to mii_bus structure
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-05-10 20:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 16:37 [PATCH 0/3] mdio: Parse DT nodes for auto-probed PHYs Daniel Mack
2014-05-10 16:37 ` [PATCH 1/3] net: of_mdio: factor out code to parse a phy's 'reg' property Daniel Mack
2014-05-10 20:29 ` Sergei Shtylyov [this message]
2014-05-13 17:07 ` David Miller
2014-05-13 17:21 ` Daniel Mack
2014-05-13 17:25 ` David Miller
2014-05-13 17:29 ` Daniel Mack
2014-05-10 16:37 ` [PATCH 2/3] net: of_mdio: add of_mdiobus_link_phydev() Daniel Mack
2014-05-23 19:35 ` Florian Fainelli
2014-05-24 7:25 ` Daniel Mack
2014-05-10 16:37 ` [PATCH 3/3] net: of_mdio: don't store the length of a property if we don't need to Daniel Mack
2014-05-13 4:33 ` [PATCH 0/3] mdio: Parse DT nodes for auto-probed PHYs Florian Fainelli
2014-05-22 18:18 ` Daniel Mack
2014-05-23 19:24 ` Florian Fainelli
2014-05-23 19:26 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536E8C0E.3040407@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=mugunthanvnm@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ujhelyi.m@gmail$(echo .)com \
--cc=zonque@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox