* Fw: [Bug 79891] New: Router causes TCP retransmits for windows hosts after "ip_forward: fix inverted local_df test"
@ 2014-07-10 13:44 Stephen Hemminger
2014-07-10 17:11 ` Cong Wang
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2014-07-10 13:44 UTC (permalink / raw)
To: netdev
Begin forwarded message:
Date: Thu, 10 Jul 2014 06:20:14 -0700
From: "bugzilla-daemon@bugzilla•kernel.org" <bugzilla-daemon@bugzilla•kernel.org>
To: "stephen@networkplumber•org" <stephen@networkplumber•org>
Subject: [Bug 79891] New: Router causes TCP retransmits for windows hosts after "ip_forward: fix inverted local_df test"
https://bugzilla.kernel.org/show_bug.cgi?id=79891
Bug ID: 79891
Summary: Router causes TCP retransmits for windows hosts after
"ip_forward: fix inverted local_df test"
Product: Networking
Version: 2.5
Kernel Version: 3.2.60
Hardware: All
OS: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: IPV4
Assignee: shemminger@linux-foundation•org
Reporter: tm@del•bg
Regression: No
Created attachment 142651
--> https://bugzilla.kernel.org/attachment.cgi?id=142651&action=edit
TCP retransmissions from a windows host
After upgrading a router to Linux 3.2.60 most windows machines behind it
started experiencing connection stalls. Downgrade to 3.2.59 resolved the
problem. Using git bisect I pinpointed it to
"59d9f389df3cdf72833d5ee17c3fe959b6bdc792 is the first bad commit", which
entered the kernel from here
http://marc.info/?l=linux-netdev&m=139949081418806&w=2
No connection problems for Linux hosts at all – only windows. Please, find
attached tcpdump packet capture demonstrating the bad behaviour.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fw: [Bug 79891] New: Router causes TCP retransmits for windows hosts after "ip_forward: fix inverted local_df test"
2014-07-10 13:44 Stephen Hemminger
@ 2014-07-10 17:11 ` Cong Wang
2014-07-11 18:11 ` Ben Hutchings
0 siblings, 1 reply; 6+ messages in thread
From: Cong Wang @ 2014-07-10 17:11 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
On Thu, Jul 10, 2014 at 6:44 AM, Stephen Hemminger
<stephen@networkplumber•org> wrote:
>
> After upgrading a router to Linux 3.2.60 most windows machines behind it
> started experiencing connection stalls. Downgrade to 3.2.59 resolved the
> problem. Using git bisect I pinpointed it to
> "59d9f389df3cdf72833d5ee17c3fe959b6bdc792 is the first bad commit", which
> entered the kernel from here
> http://marc.info/?l=linux-netdev&m=139949081418806&w=2
>
This commit should have been reverted for older kernels like 3.2.y.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fw: [Bug 79891] New: Router causes TCP retransmits for windows hosts after "ip_forward: fix inverted local_df test"
@ 2014-07-11 5:50 Teodor Milkov
0 siblings, 0 replies; 6+ messages in thread
From: Teodor Milkov @ 2014-07-11 5:50 UTC (permalink / raw)
To: netdev
I wonder if this is the same bug being discussed in the Debian bug
tracker: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754294
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fw: [Bug 79891] New: Router causes TCP retransmits for windows hosts after "ip_forward: fix inverted local_df test"
2014-07-10 17:11 ` Cong Wang
@ 2014-07-11 18:11 ` Ben Hutchings
2014-07-11 18:38 ` Cong Wang
0 siblings, 1 reply; 6+ messages in thread
From: Ben Hutchings @ 2014-07-11 18:11 UTC (permalink / raw)
To: Cong Wang; +Cc: Stephen Hemminger, netdev, David Miller, stable
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
On Thu, 2014-07-10 at 10:11 -0700, Cong Wang wrote:
> On Thu, Jul 10, 2014 at 6:44 AM, Stephen Hemminger
> <stephen@networkplumber•org> wrote:
> >
> > After upgrading a router to Linux 3.2.60 most windows machines behind it
> > started experiencing connection stalls. Downgrade to 3.2.59 resolved the
> > problem. Using git bisect I pinpointed it to
> > "59d9f389df3cdf72833d5ee17c3fe959b6bdc792 is the first bad commit", which
> > entered the kernel from here
> > http://marc.info/?l=linux-netdev&m=139949081418806&w=2
> >
>
> This commit should have been reverted for older kernels like 3.2.y.
Really? We already had fe6cc55f3a9 ("net: ip, ipv6: handle gso skbs in
forwarding path") backported in 3.2.57.
Ben.
--
Ben Hutchings
To err is human; to really foul things up requires a computer.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fw: [Bug 79891] New: Router causes TCP retransmits for windows hosts after "ip_forward: fix inverted local_df test"
2014-07-11 18:11 ` Ben Hutchings
@ 2014-07-11 18:38 ` Cong Wang
2014-07-11 19:01 ` Ben Hutchings
0 siblings, 1 reply; 6+ messages in thread
From: Cong Wang @ 2014-07-11 18:38 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Stephen Hemminger, netdev, David Miller, stable
On Fri, Jul 11, 2014 at 11:11 AM, Ben Hutchings <ben@decadent•org.uk> wrote:
> On Thu, 2014-07-10 at 10:11 -0700, Cong Wang wrote:
>> On Thu, Jul 10, 2014 at 6:44 AM, Stephen Hemminger
>> <stephen@networkplumber•org> wrote:
>> >
>> > After upgrading a router to Linux 3.2.60 most windows machines behind it
>> > started experiencing connection stalls. Downgrade to 3.2.59 resolved the
>> > problem. Using git bisect I pinpointed it to
>> > "59d9f389df3cdf72833d5ee17c3fe959b6bdc792 is the first bad commit", which
>> > entered the kernel from here
>> > http://marc.info/?l=linux-netdev&m=139949081418806&w=2
>> >
>>
>> This commit should have been reverted for older kernels like 3.2.y.
>
> Really? We already had fe6cc55f3a9 ("net: ip, ipv6: handle gso skbs in
> forwarding path") backported in 3.2.57.
I haven't read the code, but according to a previous discussion it sounds
like that should be reverted:
http://lists.openwall.net/netdev/2014/06/11/67
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fw: [Bug 79891] New: Router causes TCP retransmits for windows hosts after "ip_forward: fix inverted local_df test"
2014-07-11 18:38 ` Cong Wang
@ 2014-07-11 19:01 ` Ben Hutchings
0 siblings, 0 replies; 6+ messages in thread
From: Ben Hutchings @ 2014-07-11 19:01 UTC (permalink / raw)
To: Cong Wang; +Cc: Stephen Hemminger, netdev, David Miller, stable
[-- Attachment #1: Type: text/plain, Size: 1453 bytes --]
On Fri, 2014-07-11 at 11:38 -0700, Cong Wang wrote:
> On Fri, Jul 11, 2014 at 11:11 AM, Ben Hutchings <ben@decadent•org.uk> wrote:
> > On Thu, 2014-07-10 at 10:11 -0700, Cong Wang wrote:
> >> On Thu, Jul 10, 2014 at 6:44 AM, Stephen Hemminger
> >> <stephen@networkplumber•org> wrote:
> >> >
> >> > After upgrading a router to Linux 3.2.60 most windows machines behind it
> >> > started experiencing connection stalls. Downgrade to 3.2.59 resolved the
> >> > problem. Using git bisect I pinpointed it to
> >> > "59d9f389df3cdf72833d5ee17c3fe959b6bdc792 is the first bad commit", which
> >> > entered the kernel from here
> >> > http://marc.info/?l=linux-netdev&m=139949081418806&w=2
> >> >
> >>
> >> This commit should have been reverted for older kernels like 3.2.y.
> >
> > Really? We already had fe6cc55f3a9 ("net: ip, ipv6: handle gso skbs in
> > forwarding path") backported in 3.2.57.
>
> I haven't read the code, but according to a previous discussion it sounds
> like that should be reverted:
>
> http://lists.openwall.net/netdev/2014/06/11/67
My reading of that is we need 895162b1101b ("netfilter: ipv4: defrag:
set local_df flag on defragmented skb") in 3.2.y and 3.4.y. But there
seem to be many other places that local_df should be set, that have only
recently been fixed. So maybe reverting is the safer option.
Ben.
--
Ben Hutchings
To err is human; to really foul things up requires a computer.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-11 19:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-11 5:50 Fw: [Bug 79891] New: Router causes TCP retransmits for windows hosts after "ip_forward: fix inverted local_df test" Teodor Milkov
-- strict thread matches above, loose matches on Subject: below --
2014-07-10 13:44 Stephen Hemminger
2014-07-10 17:11 ` Cong Wang
2014-07-11 18:11 ` Ben Hutchings
2014-07-11 18:38 ` Cong Wang
2014-07-11 19:01 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox