From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>, netdev@vger•kernel.org
Cc: "David S. Miller" <davem@davemloft•net>,
Cong Wang <cwang@twopensource•com>
Subject: Re: [Patch net-next] net_sched: hold tcf_lock in netdevice notifier
Date: Thu, 17 Jul 2014 08:49:57 -0400 [thread overview]
Message-ID: <53C7C675.7090400@mojatatu.com> (raw)
In-Reply-To: <1405545931-13832-2-git-send-email-xiyou.wangcong@gmail.com>
On 07/16/14 17:25, Cong Wang wrote:
> From: Cong Wang <cwang@twopensource•com>
>
> We modify mirred action (m->tcfm_dev) in netdev event, we need to
> prevent on-going mirred actions from reading freed m->tcfm_dev.
> So we need to acquire this spin lock.
>
Cong,
What setup prompted this? We have no problems dealing with deleted
devices in the data path. It seems harmless otherwise.
cheers,
jamal
next prev parent reply other threads:[~2014-07-17 12:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 21:25 [Patch net-next] net_sched: cancel nest attribute on failure in tcf_exts_dump() Cong Wang
2014-07-16 21:25 ` [Patch net-next] net_sched: hold tcf_lock in netdevice notifier Cong Wang
2014-07-17 12:49 ` Jamal Hadi Salim [this message]
2014-07-17 16:45 ` Cong Wang
2014-07-17 18:17 ` Eric Dumazet
2014-07-17 21:25 ` Cong Wang
2014-07-18 5:37 ` Eric Dumazet
2014-07-18 5:51 ` Cong Wang
2014-07-18 7:08 ` Eric Dumazet
2014-07-19 22:02 ` Jamal Hadi Salim
2014-07-17 23:01 ` David Miller
2014-07-21 3:31 ` David Miller
2014-07-17 6:51 ` [Patch net-next] net_sched: cancel nest attribute on failure in tcf_exts_dump() David Miller
2014-07-17 12:39 ` Jamal Hadi Salim
2014-07-17 21:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C7C675.7090400@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=cwang@twopensource$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox