From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Eric Dumazet <eric.dumazet@gmail•com>,
Cong Wang <xiyou.wangcong@gmail•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>,
Cong Wang <cwang@twopensource•com>
Subject: Re: [Patch net-next] net_sched: hold tcf_lock in netdevice notifier
Date: Sat, 19 Jul 2014 18:02:13 -0400 [thread overview]
Message-ID: <53CAEAE5.3090300@mojatatu.com> (raw)
In-Reply-To: <1405667332.10255.92.camel@edumazet-glaptop2.roam.corp.google.com>
On 07/18/14 03:08, Eric Dumazet wrote:
> On Thu, 2014-07-17 at 22:51 -0700, Cong Wang wrote:
>
> If this conversion was already done by John, I would have pointed the
> patch to finalize.
>
> There is nothing fundamental that requires this spinlock being held in
> fast path.
>
> It is perfectly possible to remove this, and first step is to use RCU,
> then percpu counters.
>
I think rcufication would help in some the shared action instances.
Note: post John's rcu-fication of classifier path this is not an
issue i.e
the most common use case default behavior (majority) is no sharing of
instances - in such a case there is no lock contention.
cheers,
jamal
next prev parent reply other threads:[~2014-07-19 22:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 21:25 [Patch net-next] net_sched: cancel nest attribute on failure in tcf_exts_dump() Cong Wang
2014-07-16 21:25 ` [Patch net-next] net_sched: hold tcf_lock in netdevice notifier Cong Wang
2014-07-17 12:49 ` Jamal Hadi Salim
2014-07-17 16:45 ` Cong Wang
2014-07-17 18:17 ` Eric Dumazet
2014-07-17 21:25 ` Cong Wang
2014-07-18 5:37 ` Eric Dumazet
2014-07-18 5:51 ` Cong Wang
2014-07-18 7:08 ` Eric Dumazet
2014-07-19 22:02 ` Jamal Hadi Salim [this message]
2014-07-17 23:01 ` David Miller
2014-07-21 3:31 ` David Miller
2014-07-17 6:51 ` [Patch net-next] net_sched: cancel nest attribute on failure in tcf_exts_dump() David Miller
2014-07-17 12:39 ` Jamal Hadi Salim
2014-07-17 21:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CAEAE5.3090300@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=cwang@twopensource$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox