From: Amir Vadai <amirv@mellanox•com>
To: Jean Delvare <jdelvare@suse•de>
Cc: Or Gerlitz <ogerlitz@mellanox•com>,
Jack Morgenstein <jackm@dev•mellanox.co.il>,
"David S. Miller" <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>
Subject: Re: Manual loading of mlx4_en
Date: Tue, 29 Jul 2014 13:44:54 +0300 [thread overview]
Message-ID: <53D77B26.3070905@mellanox.com> (raw)
In-Reply-To: <20140729123405.6802fbc4@endymion.delvare>
On 7/29/2014 1:34 PM, Jean Delvare wrote:
> Hi Amir,
>
> On Tue, 29 Jul 2014 13:16:42 +0300, Amir Vadai wrote:
>> On 7/29/2014 12:53 PM, Jean Delvare wrote:
>>> I have a usability concern with the mlx4_en ethernet network driver. The
>>> module aliases for all the supported devices are on the mlx4_core
>>> module, so mlx4_core gets loaded automatically, but mlx4_en does not. I
>>> must load mlx4_en manually (kernel 3.12.)
>>>
>>> May I ask why the mlx4 driver was split into mlx4_core and mlx4_en in
>>> the first place?
>> Connect-X card can support both Ethernet and Infiniband link layer - you
>> can switch between link layers without replacing the hardware.
>>
>> To prevent code duplication, there is a single lower layer driver -
>> mlx4_core and two separate upper layer drivers - mlx4_en and mlx4_ib.
>>
>> Since kernel 3.13 mlx4_core is loading automatically the upper layer
>> driver using request_module():
>> b046ffe net/mlx4_core: Load higher level modules according to ports type
>
> Many thanks for the fast and detailed answer! I'll go backport this
> commit to kernel 3.12 (and 3.0, hopefully it doesn't have too many
> dependencies?)
>
I don't think there is any dependency for that commit. If you're
backporting it, also take a small fix to it:
f24f790 net/mlx4_core: Load the Eth driver first
Amir
next prev parent reply other threads:[~2014-07-29 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 9:53 Manual loading of mlx4_en Jean Delvare
2014-07-29 10:16 ` Amir Vadai
2014-07-29 10:34 ` Jean Delvare
2014-07-29 10:44 ` Amir Vadai [this message]
2014-07-29 12:06 ` Jean Delvare
2014-07-29 13:42 ` Amir Vadai
2014-07-30 2:14 ` Benjamin Poirier
2014-07-30 7:56 ` Amir Vadai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D77B26.3070905@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jackm@dev$(echo .)mellanox.co.il \
--cc=jdelvare@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox