From: Amir Vadai <amirv@mellanox•com>
To: Benjamin Poirier <benjamin.poirier@gmail•com>
Cc: Jean Delvare <jdelvare@suse•de>,
Or Gerlitz <ogerlitz@mellanox•com>,
"Jack Morgenstein" <jackm@dev•mellanox.co.il>,
"David S. Miller" <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>
Subject: Re: Manual loading of mlx4_en
Date: Wed, 30 Jul 2014 10:56:23 +0300 [thread overview]
Message-ID: <53D8A527.1070506@mellanox.com> (raw)
In-Reply-To: <20140730021400.GA25996@f1.synalogic.ca>
On 7/30/2014 5:14 AM, Benjamin Poirier wrote:
> On 2014/07/29 16:42, Amir Vadai wrote:
>> On 7/29/2014 3:06 PM, Jean Delvare wrote:
>>> Le Tuesday 29 July 2014 à 13:44 +0300, Amir Vadai a écrit :
>>>> On 7/29/2014 1:34 PM, Jean Delvare wrote:
>>>>> Many thanks for the fast and detailed answer! I'll go backport this
>>>>> commit to kernel 3.12 (and 3.0, hopefully it doesn't have too many
>>>>> dependencies?)
>>>>
>>>> I don't think there is any dependency for that commit. If you're
>>>> backporting it, also take a small fix to it:
>>>> f24f790 net/mlx4_core: Load the Eth driver first
>>>
>>> Thanks for the hint. I suppose I should pick 7855bff4 "net/mlx4_core:
>>> Load the IB driver when the device supports IBoE" as well?
>>>
>> Right - missed it.
>
> Thanks for the pointers.
> Looking at f24f790f, I'm wondering if request_module(EN_DRV_NAME) ought
> to be used instead of _nowait to guarantee the desired effect. Suppose
> for example that the process is migrated to a different cpu between the
> two request_module calls, the second one could complete before the first
> one no?
>
The issue was addressed after the commit above, through these two
commits in a proper and robust way:
9433c18 IB/mlx4: Invoke UPDATE_QP for proxy QP1 on MAC changes
ce8d9e0 net/mlx4_core: Add UPDATE_QP SRIOV wrapper support
Thanks,
Amir
prev parent reply other threads:[~2014-07-30 7:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 9:53 Manual loading of mlx4_en Jean Delvare
2014-07-29 10:16 ` Amir Vadai
2014-07-29 10:34 ` Jean Delvare
2014-07-29 10:44 ` Amir Vadai
2014-07-29 12:06 ` Jean Delvare
2014-07-29 13:42 ` Amir Vadai
2014-07-30 2:14 ` Benjamin Poirier
2014-07-30 7:56 ` Amir Vadai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D8A527.1070506@mellanox.com \
--to=amirv@mellanox$(echo .)com \
--cc=benjamin.poirier@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jackm@dev$(echo .)mellanox.co.il \
--cc=jdelvare@suse$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox