From: jflf-kernel@gmx•com
To: David Miller <davem@davemloft•net>
Cc: nic_swsd@realtek•com, netdev@vger•kernel.org
Subject: Re: [PATCH] r8152: add missing Makefile rule
Date: Sun, 03 Aug 2014 09:52:58 +0200 [thread overview]
Message-ID: <53DDEA5A.4010008@gmx.com> (raw)
In-Reply-To: <20140802.204134.360329908595614221.davem@davemloft.net>
On 03/08/14 05:41 AM, David Miller wrote:
> From: jflf-kernel@gmx•com
> Date: Sat, 02 Aug 2014 01:26:40 +0200
>
>> Is seems that this issue has existed ever since the driver was
>> added back in 3.10. In Linus' git tree the drivers/net/Makefile was
>> last modified before the inclusion of the driver, so I don't know
>> if it's ever been possible to build it.
>
> It gets built, as long as at least one other USB networking driver has
> been selected.
>
> Most people (distributions, developers, maintainers) select all
> drivers or some large subset thereof, so would never actually run into
> this problem.
>
> You'd have to specifically have a configuration that enabled r8152 and
> no other USB networking driver, in order to trigger this.
>
> Anyways, I'll apply this, thanks.
Very true, thank you for pointing it out. If you haven't done so yet,
the patch description could be changed to something like:
When it is the only USB net driver selected, the r8152 driver doesn't
get built because of a missing rule in drivers/net/Makefile. This change
adds the rule and lets the driver build.
Thank you!
JF
prev parent reply other threads:[~2014-08-03 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 23:26 [PATCH] r8152: add missing Makefile rule jflf-kernel
2014-08-03 3:41 ` David Miller
2014-08-03 7:52 ` jflf-kernel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DDEA5A.4010008@gmx.com \
--to=jflf-kernel@gmx$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nic_swsd@realtek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox