public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
To: David Miller <davem@davemloft•net>, vyasevich@gmail•com
Cc: netdev@vger•kernel.org, toshiaki.makita1@gmail•com, vyasevic@redhat•com
Subject: Re: [PATCH] bridge: Fix br_should_learn to check vlan_enabled
Date: Tue, 16 Sep 2014 19:40:43 +0900	[thread overview]
Message-ID: <541813AB.2060301@lab.ntt.co.jp> (raw)
In-Reply-To: <20140915.173849.609066505150727105.davem@davemloft.net>

On 2014/09/16 6:38, David Miller wrote:
> From: Vladislav Yasevich <vyasevich@gmail•com>
> Date: Mon, 15 Sep 2014 15:24:26 -0400
> 
>> As Toshiaki Makita pointed out, the BRIDGE_INPUT_SKB_CB will
>> not be initialized in br_should_learn() as that function
>> is called only from br_handle_local_finish().  That is
>> an input handler for link-local ethernet traffic so it perfectly
>> correct to check br->vlan_enabled here.
>>
>> Reported-by: Toshiaki Makita<toshiaki.makita1@gmail•com>
>> Fixes: 20adfa1 bridge: Check if vlan filtering is enabled only once.
>> Signed-off-by: Vladislav Yasevich <vyasevic@redhat•com>
> 
> Applied, thanks Vlad.

Hi David,

Could you queue this for -stable as well?
Without this, FDB can be poisoned by disallowed ports.
(the same problem as stated in e0d7968ab6c8 "bridge: Prevent insertion
of FDB entry with disallowed vlan")

Thanks,
Toshiaki Makita

next prev parent reply	other threads:[~2014-09-16 10:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15 19:24 [PATCH] bridge: Fix br_should_learn to check vlan_enabled Vladislav Yasevich
2014-09-15 21:38 ` David Miller
2014-09-16 10:40   ` Toshiaki Makita [this message]
2014-09-16 14:02     ` Toshiaki Makita
2014-09-16 16:16       ` David Miller
2014-09-16 16:05     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541813AB.2060301@lab.ntt.co.jp \
    --to=makita.toshiaki@lab$(echo .)ntt.co.jp \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=toshiaki.makita1@gmail$(echo .)com \
    --cc=vyasevic@redhat$(echo .)com \
    --cc=vyasevich@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox