From: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
To: vyasevic@redhat•com, Toshiaki Makita <toshiaki.makita1@gmail•com>,
Vladislav Yasevich <vyasevich@gmail•com>,
netdev@vger•kernel.org
Cc: shemminger@vyatta•com, bridge@lists•linux-foundation.org
Subject: Re: [PATCH 2/3] bridge: Add filtering support for default_pvid
Date: Tue, 16 Sep 2014 20:10:11 +0900 [thread overview]
Message-ID: <54181A93.2070604@lab.ntt.co.jp> (raw)
In-Reply-To: <5417011D.2000301@redhat.com>
On 2014/09/16 0:09, Vlad Yasevich wrote:
> On 09/14/2014 11:21 AM, Toshiaki Makita wrote:
>> (14/09/13 (土) 5:44), Vladislav Yasevich wrote:
>>> Currently when vlan filtering is turned on on the bridge, the bridge
>>> will drop all traffic untill the user configures the filter. This
>>> isn't very nice for ports that don't care about vlans and just
>>> want untagged traffic.
>>>
>>> A concept of a default_pvid was recently introduced. This patch
>>> adds filtering support for default_pvid. Now, ports that don't
>>> care about vlans and don't define there own filter will belong
>>> to the VLAN of the default_pvid and continue to receive untagged
>>> traffic.
>>
>> If user sets pvid, then vid 1 (default_pvid) will become non-pvid but
>> still not be filtered, right?
>
> Right.
>
>> vlan_bitmap of default_pvid shouldn't be cleared on setting pvid?
>
> I can see arguments for both. Just because the user wishes to set a
> different pvid may not always mean that vlan associated with default pvid
> shouldn't be filtered. I think it's at user's discretion. I hesitate
> to do too many things automatically.
On second thought, I agree with you.
It's reasonable that what default_pvid should do is only to set pvid on
adding a bridge/port.
My another concern is how we can disable default_pvid, since this
feature is originally non-existent.
Thanks,
Toshiaki Makita
next prev parent reply other threads:[~2014-09-16 11:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 20:44 [PATCH 0/3] bridge: Some nice new things for vlan filtering Vladislav Yasevich
2014-09-12 20:44 ` [PATCH 1/3] bridge: Add a default_pvid sysfs attribute Vladislav Yasevich
2014-09-12 20:44 ` [PATCH 2/3] bridge: Add filtering support for default_pvid Vladislav Yasevich
2014-09-14 15:21 ` Toshiaki Makita
2014-09-15 15:09 ` [Bridge] " Vlad Yasevich
2014-09-16 11:10 ` Toshiaki Makita [this message]
2014-09-16 13:23 ` Vlad Yasevich
2014-09-12 20:44 ` [PATCH 3/3] bridge; Automatically filter vlans configured on top of bridge Vladislav Yasevich
2014-09-14 15:39 ` [Bridge] " Toshiaki Makita
2014-09-15 15:19 ` Vlad Yasevich
2014-09-16 11:28 ` Toshiaki Makita
2014-09-16 13:31 ` Vlad Yasevich
2014-09-16 14:39 ` Toshiaki Makita
2014-09-16 15:00 ` Vlad Yasevich
2014-09-17 0:25 ` Toshiaki Makita
2014-09-17 14:14 ` Vlad Yasevich
2014-09-18 9:47 ` Toshiaki Makita
2014-09-15 16:24 ` [PATCH 0/3] bridge: Some nice new things for vlan filtering Stephen Hemminger
2014-09-16 11:38 ` Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54181A93.2070604@lab.ntt.co.jp \
--to=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
--cc=toshiaki.makita1@gmail$(echo .)com \
--cc=vyasevic@redhat$(echo .)com \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox