From: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
To: vyasevic@redhat•com, Toshiaki Makita <toshiaki.makita1@gmail•com>,
Vladislav Yasevich <vyasevich@gmail•com>,
netdev@vger•kernel.org
Cc: shemminger@vyatta•com, bridge@lists•linux-foundation.org
Subject: Re: [PATCH 3/3] bridge; Automatically filter vlans configured on top of bridge
Date: Wed, 17 Sep 2014 09:25:23 +0900 [thread overview]
Message-ID: <5418D4F3.5070701@lab.ntt.co.jp> (raw)
In-Reply-To: <54185095.4020102@redhat.com>
On 2014/09/17 0:00, Vlad Yasevich wrote:
> On 09/16/2014 10:39 AM, Toshiaki Makita wrote:
>> (14/09/16 (火) 22:31), Vlad Yasevich wrote:
>>> On 09/16/2014 07:28 AM, Toshiaki Makita wrote:
>>>> On 2014/09/16 0:19, Vlad Yasevich wrote:
>>>>> On 09/14/2014 11:39 AM, Toshiaki Makita wrote:
>>>>>> (14/09/13 (土) 5:44), Vladislav Yasevich wrote:
>>>>>>> If the user configures vlan devices on top of the bridge,
>>>>>>> automatically set up filter entries for it as long as
>>>>>>> bridge vlan protocol matches that of the vlan.
>>>>>>> This allows the user to atomatically receive vlan traffic
>>>>>>> for the vlans that are convifgured.
>>>>>>
>>>>>> Changing br->vlan_proto seems to cause inconsistency between vlan
>>>>>> interfaces and filter settings.
>>>>>> Can we automatically change filters when setting vlan_proto?
>>>>>>
>>>>>
>>>>> I thought we already do that in br_vlan_set_proto()? Nothing
>>>>> here introduces any new kinds of issue with that code.
>>>>
>>>> I'm referring to a case like this:
>>>> 1. create br0.10 (802.1ad)
>>>> 2. change br->vlan_proto into 88a8
>>>>
>>>> When creating br0.10 (1), br->vlan_proto is 8100 and different from
>>>> protocol of br0.10, so it is ignored by br_vlan_rx_add_vid().
>>>> After changing br->vlan_proto (2), we might expect vlan 10 is not
>>>> filtered on br0, but it will be filtered.
>>>
>>> Ok, I see what you mean. This one is a bit tough. Our options are:
>>> 1) Return an error when configuring br0.10. This might break user-space. Not good.
>>> 2) Ignore protocol when crating the filter. This is not good either as the user
>>> may not switch the bridge vlan_proto value and we'd end up with a wrong filter.
>>> 3) Re-implement .1ad support per-vlan instead of per-bridge.
>>>
>>> You see another other alternatives?
>>
>> We might be able to configure filterings on changing vlan_proto.
>> 4) Memorize different protocol's filtering requests in
>> br_vlan_rx_add_vid() and use them when switching vlan_proto.
>
> If we do this, we might as well take it one small step further and make per-vlan protocol
> support.
>
>> 5) Scan vlan devices on bridge device when changing vlan_proto.
>>
>
> The scan could work... walk the upper devices looking for vlans and add/delete filters
> based on the protocol of the vlan devices.
>
> Seems kind of hacky, but let me give this one a try...
dev->vlan_info->vid_list might be a more appropriate list since
vlan_vid_add() can be called not only by vlan devices.
Thanks,
Toshiaki Makita
next prev parent reply other threads:[~2014-09-17 0:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 20:44 [PATCH 0/3] bridge: Some nice new things for vlan filtering Vladislav Yasevich
2014-09-12 20:44 ` [PATCH 1/3] bridge: Add a default_pvid sysfs attribute Vladislav Yasevich
2014-09-12 20:44 ` [PATCH 2/3] bridge: Add filtering support for default_pvid Vladislav Yasevich
2014-09-14 15:21 ` Toshiaki Makita
2014-09-15 15:09 ` [Bridge] " Vlad Yasevich
2014-09-16 11:10 ` Toshiaki Makita
2014-09-16 13:23 ` Vlad Yasevich
2014-09-12 20:44 ` [PATCH 3/3] bridge; Automatically filter vlans configured on top of bridge Vladislav Yasevich
2014-09-14 15:39 ` [Bridge] " Toshiaki Makita
2014-09-15 15:19 ` Vlad Yasevich
2014-09-16 11:28 ` Toshiaki Makita
2014-09-16 13:31 ` Vlad Yasevich
2014-09-16 14:39 ` Toshiaki Makita
2014-09-16 15:00 ` Vlad Yasevich
2014-09-17 0:25 ` Toshiaki Makita [this message]
2014-09-17 14:14 ` Vlad Yasevich
2014-09-18 9:47 ` Toshiaki Makita
2014-09-15 16:24 ` [PATCH 0/3] bridge: Some nice new things for vlan filtering Stephen Hemminger
2014-09-16 11:38 ` Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5418D4F3.5070701@lab.ntt.co.jp \
--to=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
--cc=toshiaki.makita1@gmail$(echo .)com \
--cc=vyasevic@redhat$(echo .)com \
--cc=vyasevich@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox