From: Jamal Hadi Salim <jhs@mojatatu•com>
To: John Fastabend <john.fastabend@gmail•com>,
Cong Wang <xiyou.wangcong@gmail•com>
Cc: John Fastabend <john.r.fastabend@intel•com>,
netdev <netdev@vger•kernel.org>
Subject: Re: tc rsvp filter show broke
Date: Sun, 28 Sep 2014 14:48:18 -0400 [thread overview]
Message-ID: <542857F2.8090100@mojatatu.com> (raw)
In-Reply-To: <54284A51.5080805@gmail.com>
On 09/28/14 13:50, John Fastabend wrote:
> On 09/28/2014 10:15 AM, Cong Wang wrote:
> act->type = exts->type = TCA_OLD_COMPAT;
> list_add(&act->list, &exts->actions);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
Right.
Note, this exts->xx thing we should eventually kill. It was intended to
allow for old binary compatibility (for about 10 years now).
In the earlier days, policer was a speacial action and one could invoke
it directly from "tc filter ....."
But over time, the more sane way is:
"tc filter .. action police ..."
We have killed ability to compile in the kernel policer to support to
allow old tools to continue to use it at least 5 years ago.
tc still has support but I doubt if anyone uses it. Otherwise there
would have been a lot of fallout from
commit 4bfb21ca2043dc5251102e4debcc0ae27f7304e7 in iproute2.
So if there are any takers for patches, i think the first thing is
to kill every call in iproute2 which calls police directly.
And if nobody whines, then get rid of most of exts->XXX (at minimal
there would be no need for exts->police)
cheers,
jamal
next prev parent reply other threads:[~2014-09-28 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 17:41 tc rsvp filter show broke John Fastabend
2014-09-26 22:48 ` Jamal Hadi Salim
2014-09-26 23:25 ` John Fastabend
2014-09-28 15:05 ` Jamal Hadi Salim
2014-09-28 17:15 ` Cong Wang
2014-09-28 17:50 ` John Fastabend
2014-09-28 18:48 ` Jamal Hadi Salim [this message]
2014-09-29 1:40 ` Cong Wang
2014-09-29 5:34 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542857F2.8090100@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=john.r.fastabend@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox