public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>, netdev@vger•kernel.org
Cc: John Fastabend <john.r.fastabend@intel•com>,
	"David S. Miller" <davem@davemloft•net>
Subject: Re: [Patch net-next] net_sched: refactor out tcf_exts
Date: Mon, 06 Oct 2014 07:09:49 -0400	[thread overview]
Message-ID: <5432787D.90808@mojatatu.com> (raw)
In-Reply-To: <1412376709-25564-1-git-send-email-xiyou.wangcong@gmail.com>

On 10/03/14 18:51, Cong Wang wrote:
> As Jamal pointed it out, tcf_exts is really unnecessary,
> we can definitely refactor it out without losing any functionality.
> This could also remove an indirect layer which makes the code
> much easier to read.
>
> This patch:
>
> 1) moves exts->action and exts->police into tp->ops, since they
> are statically assigned
>
> 2) moves exts->actions list head out
>
> 3) removes exts->type, act->type does the same thing
>
> 4) renames tcf_exts_*() functions to tcf_act_*()
>
> Cc: Jamal Hadi Salim <jhs@mojatatu•com>
> Cc: John Fastabend <john.r.fastabend@intel•com>
> Cc: "David S. Miller" <davem@davemloft•net>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail•com>

Thanks for doing the work Cong.
I noticed John points to an issue in his testing; but
please add my:
Acked-by: Jamal Hadi Salim <jhs@mojatatu•com>

I will start sending incremental patches to iproute2 to slowly get
rid of direct police interfacing which will allow us to get rid of
.police dereference altogether.
It was a mistake not to do it years ago.
One way to accelerate it right now is to log a "deprecated"
message everytime someone uses TCA_XXX_POLICE attributes.

cheers,
jamal

next prev parent reply	other threads:[~2014-10-06 11:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 22:51 [Patch net-next] net_sched: refactor out tcf_exts Cong Wang
2014-10-06  1:47 ` John Fastabend
2014-10-06  3:04   ` John Fastabend
2014-10-06 16:56     ` Cong Wang
2014-10-06 11:09 ` Jamal Hadi Salim [this message]
2014-10-06 11:20 ` Jamal Hadi Salim
2014-10-06 16:56   ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5432787D.90808@mojatatu.com \
    --to=jhs@mojatatu$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=john.r.fastabend@intel$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=xiyou.wangcong@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox