From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Yoshihiro Kaneko <ykaneko0929@gmail•com>, netdev@vger•kernel.org
Cc: "David S. Miller" <davem@davemloft•net>,
Simon Horman <horms@verge•net.au>,
Magnus Damm <magnus.damm@gmail•com>,
linux-sh@vger•kernel.org
Subject: Re: [PATCH v2] sh_eth: Optimization for RX excess judgement
Date: Mon, 08 Dec 2014 14:47:25 +0300 [thread overview]
Message-ID: <54858FCD.3080206@cogentembedded.com> (raw)
In-Reply-To: <1418035701-3871-1-git-send-email-ykaneko0929@gmail.com>
Hello.
On 12/8/2014 1:48 PM, Yoshihiro Kaneko wrote:
> From: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas•com>
> Both of 'boguscnt' and 'quota' have nearly meaning as the condition of
> the reception loop.
> In order to cut down redundant processing, this patch changes excess
> judgement.
> Signed-off-by: Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas•com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail•com>
> ---
> This patch is based on net-next tree.
> v2 [Yoshihiro Kaneko]
> * re-spin for net-next.
> * remove unneeded check of "quota".
This is not a complete list. :-/
> drivers/net/ethernet/renesas/sh_eth.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index dbe8606..266c9b2 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
[...]
> @@ -1501,6 +1499,8 @@ static int sh_eth_rx(struct net_device *ndev, u32 intr_status, int *quota)
> sh_eth_write(ndev, EDRRR_R, EDRRR);
> }
>
> + *quota -= limit - boguscnt + 1;
> +
Sorry for the wrong previous suggestion, it clearly should have been -1,
not +1. :-<
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-12-08 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 10:48 [PATCH v2] sh_eth: Optimization for RX excess judgement Yoshihiro Kaneko
2014-12-08 11:47 ` Sergei Shtylyov [this message]
2014-12-08 12:16 ` Yoshihiro Kaneko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54858FCD.3080206@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=horms@verge$(echo .)net.au \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=magnus.damm@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ykaneko0929@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox