From: roopa <roopa@cumulusnetworks•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: sfeldma@gmail•com, jhs@mojatatu•com, bcrl@kvack•org,
tgraf@suug•ch, john.fastabend@gmail•com,
stephen@networkplumber•org, vyasevic@redhat•com,
ronen.arad@intel•com, netdev@vger•kernel.org,
davem@davemloft•net, shm@cumulusnetworks•com,
gospo@cumulusnetworks•com
Subject: Re: [PATCH net-next v3 2/5] swdevice: add new api to set and del bridge port attributes
Date: Fri, 23 Jan 2015 14:45:46 -0800 [thread overview]
Message-ID: <54C2CF1A.1080905@cumulusnetworks.com> (raw)
In-Reply-To: <20150123160636.GM2065@nanopsycho.orion>
On 1/23/15, 8:06 AM, Jiri Pirko wrote:
> Fri, Jan 23, 2015 at 04:58:57PM CET, roopa@cumulusnetworks•com wrote:
>> On 1/23/15, 2:41 AM, Jiri Pirko wrote:
>>
>> <snip..>
>>> +
>>> +/**
>>> + * netdev_switch_port_bridge_dellink - Notify switch device port of bridge
>>> + * attribute delete
>>> + *
>>> + * @dev: port device
>>> + * @nlh: netlink msg with bridge port attributes
>>> + *
>>> + * Notify switch device port of bridge port attribute delete
>>> + */
>>> +int netdev_switch_port_bridge_dellink(struct net_device *dev,
>>> + struct nlmsghdr *nlh, u16 flags)
>>> +{
>>> + const struct net_device_ops *ops = dev->netdev_ops;
>>> + struct net_device *lower_dev;
>>> + struct list_head *iter;
>>> + int ret = 0, err = 0;
>>> +
>>> + if (!(dev->features & NETIF_F_HW_NETFUNC_OFFLOAD))
>>> + return err;
>>> +
>>> + if (ops->ndo_bridge_dellink) {
>>> + WARN_ON(!ops->ndo_switch_parent_id_get);
>>> + return ops->ndo_bridge_dellink(dev, nlh, flags);
>>> + }
>>> +
>>> + netdev_for_each_lower_dev(dev, lower_dev, iter) {
>>> + err = netdev_switch_port_bridge_dellink(lower_dev, nlh, flags);
>>> + if (err)
>>> + ret = err;
>>> + }
>>> +
>>> + return ret;
>>> +}
>>> +EXPORT_SYMBOL(netdev_switch_port_bridge_dellink);
>>> --
>>> 1.7.10.4
>>>
>>> Is there any other place, other than bridge code, this functions are
>>> suppored to be called from?
>> No other place today. Its usually the master that implements
>> ndo_bridge_setlink/dellink.
>>
>>> If not, which I consider likely, it would
>>> make more sense to me to:
>>>
>>> - move netdev_for_each_lower_dev iterations directly to bridge code
>>> - let the masters (bond, team, ..) implement ndo_bridge_*link and do
>>> the traversing there (can be in a form of pre-prepared default
>>> ndo callback (ndo_dflt_netdev_switch_port_bridge_*link)
>> But, i am still not understanding why i would modify bond, team and other
>> slaves
> Well, that is the usual way to propagate ndo calls. People are used to
> this. It is visible right away in bonding/other code that is propagated
> some ndo call to slaves. With your code, that is somehow hidden and only
> dependent on NETIF_F_HW_NETFUNC_OFFLOAD flag.
>
> Note that there are only couple of "master drivers" (for this, most likely
> only bond and team modifications are needed).
>
ndo_bridge_setlink today is only implemented by drivers that implement
bridging function.
So, having the bond and team driver implement it...seems odd.
But if you insist, i am going to do just that.
next prev parent reply other threads:[~2015-01-23 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 4:33 [PATCH net-next v3 2/5] swdevice: add new api to set and del bridge port attributes roopa
2015-01-23 10:41 ` Jiri Pirko
2015-01-23 15:58 ` roopa
2015-01-23 16:06 ` Jiri Pirko
2015-01-23 22:45 ` roopa [this message]
2015-01-23 23:10 ` roopa
2015-01-24 11:26 ` Jiri Pirko
2015-01-25 1:03 ` roopa
2015-01-23 11:24 ` Rosen, Rami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C2CF1A.1080905@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=bcrl@kvack$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ronen.arad@intel$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox