From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Sathya Perla <sathya.perla@emulex•com>, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 2/9] be2net: replace (1 << x) with BIT(x)
Date: Mon, 16 Feb 2015 15:09:24 +0300 [thread overview]
Message-ID: <54E1DDF4.5040901@cogentembedded.com> (raw)
In-Reply-To: <1423228723-10919-3-git-send-email-sathya.perla@emulex.com>
Hello.
On 2/6/2015 4:18 PM, Sathya Perla wrote:
> From: Vasundhara Volam <vasundhara.volam@emulex•com>
> BIT(x) is the preffered usage.
Preferred.
> Signed-off-by: Vasundhara Volam <vasundhara.volam@emulex•com>
> Signed-off-by: Sathya Perla <sathya.perla@emulex•com>
[...]
> diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
> index 3b1d59d..9869556 100644
> --- a/drivers/net/ethernet/emulex/benet/be.h
> +++ b/drivers/net/ethernet/emulex/benet/be.h
> @@ -361,15 +361,15 @@ enum vf_state {
> ASSIGNED = 1
> };
>
> -#define BE_FLAGS_LINK_STATUS_INIT 1
> -#define BE_FLAGS_SRIOV_ENABLED (1 << 2)
> -#define BE_FLAGS_WORKER_SCHEDULED (1 << 3)
> -#define BE_FLAGS_VLAN_PROMISC (1 << 4)
> -#define BE_FLAGS_MCAST_PROMISC (1 << 5)
> -#define BE_FLAGS_NAPI_ENABLED (1 << 9)
> -#define BE_FLAGS_QNQ_ASYNC_EVT_RCVD (1 << 11)
> -#define BE_FLAGS_VXLAN_OFFLOADS (1 << 12)
> -#define BE_FLAGS_SETUP_DONE (1 << 13)
> +#define BE_FLAGS_LINK_STATUS_INIT BIT(1)
Not BIT(0)?
> +#define BE_FLAGS_SRIOV_ENABLED BIT(2)
> +#define BE_FLAGS_WORKER_SCHEDULED BIT(3)
> +#define BE_FLAGS_VLAN_PROMISC BIT(4)
> +#define BE_FLAGS_MCAST_PROMISC BIT(5)
> +#define BE_FLAGS_NAPI_ENABLED BIT(6)
> +#define BE_FLAGS_QNQ_ASYNC_EVT_RCVD BIT(7)
> +#define BE_FLAGS_VXLAN_OFFLOADS BIT(8)
> +#define BE_FLAGS_SETUP_DONE BIT(9)
So, you decided to renumber the bits?
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-02-16 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 13:18 [PATCH net-next 0/9] be2net: patch set Sathya Perla
2015-02-06 13:18 ` [PATCH net-next 1/9] be2net: move un-exported routines from be.h to respective src files Sathya Perla
2015-02-06 13:18 ` [PATCH net-next 2/9] be2net: replace (1 << x) with BIT(x) Sathya Perla
2015-02-16 12:09 ` Sergei Shtylyov [this message]
2015-02-16 12:55 ` Sathya Perla
2015-02-16 13:13 ` Sergei Shtylyov
2015-02-06 13:18 ` [PATCH net-next 3/9] be2net: refactor code that checks flash file compatibility Sathya Perla
2015-02-06 13:18 ` [PATCH net-next 4/9] be2net: avoid flashing SH-B0 UFI image on SH-P2 chip Sathya Perla
2015-02-06 13:18 ` [PATCH net-next 5/9] be2net: use offset based FW flashing for Skyhawk chip Sathya Perla
2015-02-06 13:18 ` [PATCH net-next 6/9] be2net: remove duplicate code in be_cmd_rx_filter() Sathya Perla
2015-02-06 13:18 ` [PATCH net-next 7/9] be2net: refactor be_set_rx_mode() and be_vid_config() for readability Sathya Perla
2015-02-06 13:18 ` [PATCH net-next 8/9] be2net: process port misconfig async event Sathya Perla
2015-02-06 13:18 ` [PATCH net-next 9/9] be2net: avoid unncessary swapping of fields in eth_tx_wrb Sathya Perla
2015-02-08 6:52 ` [PATCH net-next 0/9] be2net: patch set David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E1DDF4.5040901@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sathya.perla@emulex$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox