From: Giuseppe CAVALLARO <peppe.cavallaro@st•com>
To: Richard Cochran <richardcochran@gmail•com>, <netdev@vger•kernel.org>
Cc: linux-kernel@vger•kernel.org, "Amir Vadai" <amirv@mellanox•com>,
"Ariel Elior" <ariel.elior@qlogic•com>,
"Arnd Bergmann" <arnd@linaro•org>,
"Baolin Wang" <baolin.wang@linaro•org>,
"Ben Hutchings" <ben@decadent•org.uk>,
"Bruce Allan" <bruce.w.allan@intel•com>,
"Carolyn Wyborny" <carolyn.wyborny@intel•com>,
"Chris Metcalf" <cmetcalf@ezchip•com>,
"David Miller" <davem@davemloft•net>,
"Frank Li" <Frank.Li@freescale•com>,
"Jeff Kirsher" <jeffrey.t.kirsher@intel•com>,
"John Stultz" <john.stultz@linaro•org>,
"Luwei Zhou" <b45643@freescale•com>,
"Matthew Vick" <matthew.vick@intel•com>,
"Michael Chan" <mchan@broadcom•com>,
"Prashant Sreedharan" <prashant@broadcom•com>,
"Shradha Shah" <sshah@solarflare•com>,
"Solarflare linux maintainers" <linux-net-drivers@solarflare•com>,
"Sonic Zhang" <sonic.zhang@analog•com>,
"Stefan Sørensen" <stefan.sorensen@spectralink•com>,
"Thomas Gleixner" <tglx@lin>
Subject: Re: [PATCH net-next V2 17/23] ptp: stmmac: convert to the 64 bit get/set time methods.
Date: Mon, 23 Mar 2015 16:35:06 +0100 [thread overview]
Message-ID: <551032AA.3060906@st.com> (raw)
In-Reply-To: <009374d77dee7633ab0ef1a5d95182b45aaa3f18.1426973658.git.richardcochran@gmail.com>
On 3/21/2015 10:39 PM, Richard Cochran wrote:
> This device stores the number of seconds in a 32 bit register. So
> more work is needed on this driver before the year 2038 comes around.
>
> Compile tested only.
I cannot perform tests on my side, unfortunately. I have no setup at
this moment. Added Rayagond on copy too
Peppe
>
> Signed-off-by: Richard Cochran <richardcochran@gmail•com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> index c5ee79d8..172f318 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> @@ -105,7 +105,7 @@ static int stmmac_adjust_time(struct ptp_clock_info *ptp, s64 delta)
> * Description: this function will read the current time from the
> * hardware clock and store it in @ts.
> */
> -static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec *ts)
> +static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec64 *ts)
> {
> struct stmmac_priv *priv =
> container_of(ptp, struct stmmac_priv, ptp_clock_ops);
> @@ -135,7 +135,7 @@ static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec *ts)
> * hardware clock.
> */
> static int stmmac_set_time(struct ptp_clock_info *ptp,
> - const struct timespec *ts)
> + const struct timespec64 *ts)
> {
> struct stmmac_priv *priv =
> container_of(ptp, struct stmmac_priv, ptp_clock_ops);
> @@ -168,8 +168,8 @@ static struct ptp_clock_info stmmac_ptp_clock_ops = {
> .pps = 0,
> .adjfreq = stmmac_adjust_freq,
> .adjtime = stmmac_adjust_time,
> - .gettime = stmmac_get_time,
> - .settime = stmmac_set_time,
> + .gettime64 = stmmac_get_time,
> + .settime64 = stmmac_set_time,
> .enable = stmmac_enable,
> };
>
>
next prev parent reply other threads:[~2015-03-23 15:35 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 21:39 [PATCH net-next V2 00/23] ptp: get ready for 2038 Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 01/23] ptp: introduce get/set time methods with explicit 64 bit seconds Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 02/23] ptp: use the 64 bit gettime method for the SYS_OFFSET ioctl Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 03/23] ptp: use the 64 bit get/set time methods for the posix clock Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 04/23] ptp: blackfin: convert to the 64 bit get/set time methods Richard Cochran
2015-03-22 2:28 ` Arnd Bergmann
2015-03-22 7:27 ` Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 05/23] ptp: xgbe: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 06/23] ptp: bnx2x: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 07/23] ptp: tg3: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 08/23] ptp: fec: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 09/23] ptp: gianfar: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 10/23] ptp: e1000e: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 11/23] ptp: fm10k: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 12/23] ptp: i40e: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 13/23] ptp: igb: " Richard Cochran
2015-03-22 2:40 ` Arnd Bergmann
2015-03-21 21:39 ` [PATCH net-next V2 14/23] ptp: ixgbe: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 15/23] ptp: mlx4: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 16/23] ptp: sfc: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 17/23] ptp: stmmac: " Richard Cochran
2015-03-23 15:35 ` Giuseppe CAVALLARO [this message]
2015-03-31 13:22 ` Rayagond Kokatanur
2015-03-21 21:39 ` [PATCH net-next V2 18/23] ptp: cpts: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 19/23] ptp: tilegx: " Richard Cochran
2015-03-23 16:02 ` Chris Metcalf
2015-03-23 16:58 ` Richard Cochran
2015-03-23 17:26 ` Chris Metcalf
2015-03-23 20:06 ` Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 20/23] ptp: dp83640: " Richard Cochran
2015-03-22 2:36 ` Arnd Bergmann
2015-03-22 7:29 ` Richard Cochran
2015-03-22 17:48 ` Arnd Bergmann
2015-03-23 8:10 ` Richard Cochran
2015-03-23 15:06 ` Arnd Bergmann
2015-03-21 21:39 ` [PATCH net-next V2 21/23] ptp: ixp46x: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 22/23] ptp: pch: " Richard Cochran
2015-03-21 21:39 ` [PATCH net-next V2 23/23] ptp: remove 32 bit get/set methods Richard Cochran
2015-03-22 2:43 ` [PATCH net-next V2 00/23] ptp: get ready for 2038 Arnd Bergmann
2015-03-23 10:16 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551032AA.3060906@st.com \
--to=peppe.cavallaro@st$(echo .)com \
--cc=Frank.Li@freescale$(echo .)com \
--cc=amirv@mellanox$(echo .)com \
--cc=ariel.elior@qlogic$(echo .)com \
--cc=arnd@linaro$(echo .)org \
--cc=b45643@freescale$(echo .)com \
--cc=baolin.wang@linaro$(echo .)org \
--cc=ben@decadent$(echo .)org.uk \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=carolyn.wyborny@intel$(echo .)com \
--cc=cmetcalf@ezchip$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=john.stultz@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=matthew.vick@intel$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=prashant@broadcom$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=sonic.zhang@analog$(echo .)com \
--cc=sshah@solarflare$(echo .)com \
--cc=stefan.sorensen@spectralink$(echo .)com \
--cc=tglx@lin \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox