From: roopa <roopa@cumulusnetworks•com>
To: sfeldma@gmail•com
Cc: netdev@vger•kernel.org, jiri@resnulli•us, linux@roeck-us•net,
f.fainelli@gmail•com, sridhar.samudrala@intel•com,
ronen.arad@intel•com, andrew@lunn•ch
Subject: Re: [PATCH net-next v4 19/24] switchdev: add new swdev_port_bridge_getlink
Date: Mon, 13 Apr 2015 22:47:11 -0700 [thread overview]
Message-ID: <552CA9DF.8060808@cumulusnetworks.com> (raw)
In-Reply-To: <1428905838-14920-20-git-send-email-sfeldma@gmail.com>
On 4/12/15, 11:17 PM, sfeldma@gmail•com wrote:
> From: Scott Feldman <sfeldma@gmail•com>
>
> Like bridge_setlink, add swdev wrapper to handle bridge_getlink and call into
> port driver to get port attrs. For now, only BR_LEARNING and BR_LEARNING_SYNC
> are returned. To add more, we'll probably want to break away from
> ndo_dflt_bridge_getlink() and build the netlink skb directly in the swdev code.
>
> Signed-off-by: Scott Feldman <sfeldma@gmail•com>
> ---
> include/net/switchdev.h | 9 +++++++++
> net/switchdev/switchdev.c | 27 +++++++++++++++++++++++++++
> 2 files changed, 36 insertions(+)
>
> diff --git a/include/net/switchdev.h b/include/net/switchdev.h
> index 8c9814f..d04322e 100644
> --- a/include/net/switchdev.h
> +++ b/include/net/switchdev.h
> @@ -121,6 +121,8 @@ int swdev_port_attr_get(struct net_device *dev, struct swdev_attr *attr);
> int swdev_port_attr_set(struct net_device *dev, struct swdev_attr *attr);
> int swdev_port_obj_add(struct net_device *dev, struct swdev_obj *obj);
> int swdev_port_obj_del(struct net_device *dev, struct swdev_obj *obj);
> +int swdev_port_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
> + struct net_device *dev, u32 filter_mask);
> int swdev_port_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh,
> u16 flags);
> int swdev_port_bridge_dellink(struct net_device *dev, struct nlmsghdr *nlh,
> @@ -161,6 +163,13 @@ static inline int swdev_port_obj_del(struct net_device *dev,
> return -EOPNOTSUPP;
> }
>
> +static inline int swdev_port_bridge_getlink(struct sk_buff *skb, u32 pid,
> + u32 seq, struct net_device *dev,
> + u32 filter_mask)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> static inline int swdev_port_bridge_setlink(struct net_device *dev,
> struct nlmsghdr *nlh, u16 flags)
> {
> diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
> index ae0ed06..6866e0c 100644
> --- a/net/switchdev/switchdev.c
> +++ b/net/switchdev/switchdev.c
> @@ -371,6 +371,33 @@ int call_netdev_switch_notifiers(unsigned long val, struct net_device *dev,
> }
> EXPORT_SYMBOL_GPL(call_netdev_switch_notifiers);
>
> +/**
> + * swdev_port_bridge_getlink - Get bridge port attributes
> + *
> + * @dev: port device
> + *
> + * Called for SELF on rtnl_bridge_getlink to get bridge port
> + * attributes.
> + */
> +int swdev_port_bridge_getlink(struct sk_buff *skb, u32 pid, u32 seq,
> + struct net_device *dev, u32 filter_mask)
> +{
> + struct swdev_attr attr = {
> + .id = SWDEV_ATTR_PORT_BRIDGE_FLAGS,
> + };
> + u16 mode = BRIDGE_MODE_UNDEF;
> + u32 mask = BR_LEARNING | BR_LEARNING_SYNC;
> + int err;
> +
> + err = swdev_port_attr_get(dev, &attr);
> + if (err)
> + return err;
> +
> + return ndo_dflt_bridge_getlink(skb, pid, seq, dev, mode,
> + attr.brport_flags, mask);
> +}
> +EXPORT_SYMBOL_GPL(swdev_port_bridge_getlink);
This should ideally get vlans as well because setlink/dellink supports
add/del vlans.
This can however be an incremental patch. I think this was the point
arad was making as well some time back.
next prev parent reply other threads:[~2015-04-14 5:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 6:16 [PATCH net-next v4 00/24] switchdev: spring cleanup sfeldma
2015-04-13 6:16 ` [PATCH net-next v4 01/24] switchdev: introduce get/set attrs ops sfeldma
2015-04-13 10:43 ` Jiri Pirko
2015-04-14 7:02 ` Scott Feldman
2015-04-13 6:16 ` [PATCH net-next v4 02/24] switchdev: convert parent_id_get to swdev attr get sfeldma
2015-04-13 6:16 ` [PATCH net-next v4 03/24] switchdev: convert STP update to swdev attr set sfeldma
2015-04-13 19:22 ` Florian Fainelli
2015-04-14 7:51 ` Scott Feldman
2015-04-13 6:16 ` [PATCH net-next v4 04/24] switchdev: add bridge port flags attr sfeldma
2015-04-13 6:16 ` [PATCH net-next v4 05/24] rocker: use swdev get/set attr for bridge port flags sfeldma
2015-04-13 10:48 ` Jiri Pirko
2015-04-15 5:25 ` Simon Horman
2015-04-15 6:03 ` Scott Feldman
2015-04-15 8:03 ` Simon Horman
2015-04-13 6:17 ` [PATCH net-next v4 06/24] switchdev: introduce swdev add/del obj ops sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 07/24] switchdev: add port vlan obj sfeldma
2015-04-13 13:16 ` Jiri Pirko
2015-04-13 13:27 ` Jiri Pirko
2015-04-13 17:49 ` Florian Fainelli
2015-04-14 7:28 ` Scott Feldman
2015-04-13 6:17 ` [PATCH net-next v4 08/24] rocker: use swdev add/del obj for bridge port vlans sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 09/24] switchdev: add new swdev bridge setlink sfeldma
2015-04-14 4:09 ` roopa
2015-04-14 5:30 ` Jiri Pirko
2015-04-14 5:46 ` roopa
2015-04-13 6:17 ` [PATCH net-next v4 10/24] rocker: cut over to new swdev_port_bridge_setlink sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 11/24] bonding: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 12/24] team: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 13/24] switchdev: remove old netdev_switch_port_bridge_setlink sfeldma
2015-04-14 4:07 ` roopa
2015-04-13 6:17 ` [PATCH net-next v4 14/24] switchdev: add new swdev_port_bridge_dellink sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 15/24] rocker: cut over to " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 16/24] bonding: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 17/24] team: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 18/24] switchdev: remove unused netdev_switch_port_bridge_dellink sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 19/24] switchdev: add new swdev_port_bridge_getlink sfeldma
2015-04-14 5:47 ` roopa [this message]
2015-04-14 7:59 ` Scott Feldman
2015-04-13 6:17 ` [PATCH net-next v4 20/24] rocker: cut over to " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 21/24] bonding: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 22/24] team: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 23/24] switchdev: convert fib_ipv4_add/del over to swdev_port_obj_add/del sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 24/24] switchdev: bring documentation up-to-date sfeldma
2015-04-13 8:24 ` [PATCH net-next v4 00/24] switchdev: spring cleanup Jiri Pirko
2015-04-14 5:47 ` roopa
2015-04-17 4:48 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552CA9DF.8060808@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=linux@roeck-us$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ronen.arad@intel$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox