From: roopa <roopa@cumulusnetworks•com>
To: sfeldma@gmail•com
Cc: netdev@vger•kernel.org, jiri@resnulli•us, linux@roeck-us•net,
f.fainelli@gmail•com, sridhar.samudrala@intel•com,
ronen.arad@intel•com, andrew@lunn•ch
Subject: Re: [PATCH net-next v4 00/24] switchdev: spring cleanup
Date: Mon, 13 Apr 2015 22:47:56 -0700 [thread overview]
Message-ID: <552CAA0C.3030009@cumulusnetworks.com> (raw)
In-Reply-To: <1428905838-14920-1-git-send-email-sfeldma@gmail.com>
On 4/12/15, 11:16 PM, sfeldma@gmail•com wrote:
> From: Scott Feldman <sfeldma@gmail•com>
>
> v4:
>
> Well, it was a lot of work, but now prepare-commit transaction model is how
> davem advises: if prepare fails, abort the transaction. The driver must do
> resource reservations up front in prepare phase and return those resources if
> aborting. Commit phase would use reserved resources. The good news is the
> driver code (for rocker) now handles resource allocation failures better by not
> leaving partially device or driver states. This is a side-effect of the
> prepare phase where state isn't modified; only validation of inputs and
> resource reservations happen in the prepare phase. Since we're supporting
> setting attrs and add objs across lower devs in the stacked case, we need to
> hold rtnl_lock (or ensure rtnl_lock is held) so lower devs don't move on us
> during the prepare-commit transaction. DSA driver code skips the prepare phase
> and goes straight for the commit phase since no up-front allocations are done
> and no device failures (that could be detected in the prepare phase) can
> happen.
thanks for the series. It definitely does look cleaner and less
confusing now!.
I do love the abstraction but i was one of the people voting against
duplicating the
kernel objects into swdev objs which this patches does (which i am still
not convinced
we should have).
>
> Remove NETIF_F_HW_SWITCH_OFFLOAD from rocker and the swdev_attr_set/get
> wrappers. DSA doesn't set NETIF_F_HW_SWITCH_OFFLOAD, so it can't be in
> swdev_attr_set/get. rocker doesn't need it; or rather can't support
> NETIF_F_HW_SWITCH_OFFLOAD being set/cleared at run-time after the device
> port is already up and offloading L2/L3. NETIF_F_HW_SWITCH_OFFLOAD is still
> left as a feature flag for drivers that can use it.
I see that this series removes all uses of it in the switchdev api
later. I had summarized
the need for the flag in reply to one of your questions a few weeks
back. Since you have moved all
ndo ops to swdev ops (including ndo_bridge_setlink/dellink), I don't
want to hold on to the
feature flag if no one is using it. yes, my userspace driver uses it
today.
I will come back with stronger justification to keep it or
will submit a patch to remove it and add it back at a later point if needed.
Thanks,
Roopa
next prev parent reply other threads:[~2015-04-14 5:47 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 6:16 [PATCH net-next v4 00/24] switchdev: spring cleanup sfeldma
2015-04-13 6:16 ` [PATCH net-next v4 01/24] switchdev: introduce get/set attrs ops sfeldma
2015-04-13 10:43 ` Jiri Pirko
2015-04-14 7:02 ` Scott Feldman
2015-04-13 6:16 ` [PATCH net-next v4 02/24] switchdev: convert parent_id_get to swdev attr get sfeldma
2015-04-13 6:16 ` [PATCH net-next v4 03/24] switchdev: convert STP update to swdev attr set sfeldma
2015-04-13 19:22 ` Florian Fainelli
2015-04-14 7:51 ` Scott Feldman
2015-04-13 6:16 ` [PATCH net-next v4 04/24] switchdev: add bridge port flags attr sfeldma
2015-04-13 6:16 ` [PATCH net-next v4 05/24] rocker: use swdev get/set attr for bridge port flags sfeldma
2015-04-13 10:48 ` Jiri Pirko
2015-04-15 5:25 ` Simon Horman
2015-04-15 6:03 ` Scott Feldman
2015-04-15 8:03 ` Simon Horman
2015-04-13 6:17 ` [PATCH net-next v4 06/24] switchdev: introduce swdev add/del obj ops sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 07/24] switchdev: add port vlan obj sfeldma
2015-04-13 13:16 ` Jiri Pirko
2015-04-13 13:27 ` Jiri Pirko
2015-04-13 17:49 ` Florian Fainelli
2015-04-14 7:28 ` Scott Feldman
2015-04-13 6:17 ` [PATCH net-next v4 08/24] rocker: use swdev add/del obj for bridge port vlans sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 09/24] switchdev: add new swdev bridge setlink sfeldma
2015-04-14 4:09 ` roopa
2015-04-14 5:30 ` Jiri Pirko
2015-04-14 5:46 ` roopa
2015-04-13 6:17 ` [PATCH net-next v4 10/24] rocker: cut over to new swdev_port_bridge_setlink sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 11/24] bonding: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 12/24] team: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 13/24] switchdev: remove old netdev_switch_port_bridge_setlink sfeldma
2015-04-14 4:07 ` roopa
2015-04-13 6:17 ` [PATCH net-next v4 14/24] switchdev: add new swdev_port_bridge_dellink sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 15/24] rocker: cut over to " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 16/24] bonding: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 17/24] team: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 18/24] switchdev: remove unused netdev_switch_port_bridge_dellink sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 19/24] switchdev: add new swdev_port_bridge_getlink sfeldma
2015-04-14 5:47 ` roopa
2015-04-14 7:59 ` Scott Feldman
2015-04-13 6:17 ` [PATCH net-next v4 20/24] rocker: cut over to " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 21/24] bonding: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 22/24] team: " sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 23/24] switchdev: convert fib_ipv4_add/del over to swdev_port_obj_add/del sfeldma
2015-04-13 6:17 ` [PATCH net-next v4 24/24] switchdev: bring documentation up-to-date sfeldma
2015-04-13 8:24 ` [PATCH net-next v4 00/24] switchdev: spring cleanup Jiri Pirko
2015-04-14 5:47 ` roopa [this message]
2015-04-17 4:48 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552CAA0C.3030009@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=linux@roeck-us$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ronen.arad@intel$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox