From: Vladimir Zapolskiy <vz@mleia•com>
To: David Miller <davem@davemloft•net>
Cc: shahed.shaikh@qlogic•com, Dept-GELinuxNICDev@qlogic•com,
netdev@vger•kernel.org, rajesh.borundia@qlogic•com
Subject: Re: [PATCH] net: qlcnic: clean up sysfs error codes
Date: Fri, 29 May 2015 04:13:46 +0300 [thread overview]
Message-ID: <5567BD4A.6030100@mleia.com> (raw)
In-Reply-To: <20150528.162844.418918111650211346.davem@davemloft.net>
Hello David,
On 29.05.2015 02:28, David Miller wrote:
> From: Vladimir Zapolskiy <vz@mleia•com>
> Date: Tue, 26 May 2015 03:49:45 +0300
>
>> Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL
>> and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the
>> latter error code is arguable, but it is already used in the driver,
>> so let it be here as well.
>>
>> Also remove always false (!buf) check on read(), the driver should
>> not care if userspace gets its EFAULT or not.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz@mleia•com>
>
> Qlogic folks, I'm waiting for your promised feedback.
>
Rajesh reviewed and acked the change, thank you.
http://www.spinics.net/lists/netdev/msg331073.html
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2015-05-29 1:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 0:49 [PATCH] net: qlcnic: clean up sysfs error codes Vladimir Zapolskiy
2015-05-26 5:09 ` Rajesh Borundia
2015-05-28 17:42 ` Rajesh Borundia
2015-05-28 23:28 ` David Miller
2015-05-29 1:13 ` Vladimir Zapolskiy [this message]
2015-05-29 3:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5567BD4A.6030100@mleia.com \
--to=vz@mleia$(echo .)com \
--cc=Dept-GELinuxNICDev@qlogic$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rajesh.borundia@qlogic$(echo .)com \
--cc=shahed.shaikh@qlogic$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox