From: Junling Zheng <zhengjunling@huawei•com>
To: Greg KH <gregkh@linuxfoundation•org>
Cc: <lizefan@huawei•com>, <viro@zeniv•linux.org.uk>,
<davem@davemloft•net>, <xuhanbing@huawei•com>,
<stable@vger•kernel.org>, <netdev@vger•kernel.org>
Subject: Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg
Date: Tue, 2 Jun 2015 12:05:32 +0800 [thread overview]
Message-ID: <556D2B8C.9010108@huawei.com> (raw)
In-Reply-To: <20150602012154.GB23370@kroah.com>
On 2015/6/2 9:21, Greg KH wrote:
> On Mon, Jun 01, 2015 at 09:28:00AM +0000, Junling Zheng wrote:
>> Hi, Greg:
>>
>> We found that after v3.10.73, recvmsg might return -EFAULT while -EINVAL
>> was expected.
>
> That means I messed up and applied something I shouldn't have, right?
>
> Can you use 'git bisect' to find the problem patch? That's probably
> easier here, and then I can either revert it, or fix up a broken
> backport.
>
The following is the log of 'git bisect' between v3.10.72 and v3.10.73:
z00238152@Patch-Test:linux-3.10>0$ git bisect log
git bisect start
# good: [7f4e64246049cef5ae1eca37eec1701a9477799e] Linux 3.10.72
git bisect good 7f4e64246049cef5ae1eca37eec1701a9477799e
# bad: [73895725a9401bd3454757fcfa7d691270ac7498] Linux 3.10.73
git bisect bad 73895725a9401bd3454757fcfa7d691270ac7498
# bad: [d8bee0e3abef10e73a003fdc7ec04ba313334007] workqueue: fix hang involving racing cancel[_delayed]_work_sync()'s for PREEMPT_NONE
git bisect bad d8bee0e3abef10e73a003fdc7ec04ba313334007
# bad: [281c9c3601b69f1fbc492beb5976e1e2685854de] net: compat: Update get_compat_msghdr() to match copy_msghdr_from_user() behaviour
git bisect bad 281c9c3601b69f1fbc492beb5976e1e2685854de
# good: [e2f572a9be3f00bcf470a918d9e53353bea9ef4c] net: sysctl_net_core: check SNDBUF and RCVBUF for min length
git bisect good e2f572a9be3f00bcf470a918d9e53353bea9ef4c
# good: [c77b9a724d8597e1151b1fcf013560188088dc8c] caif: fix MSG_OOB test in caif_seqpkt_recvmsg()
git bisect good c77b9a724d8597e1151b1fcf013560188088dc8c
# good: [742c1c523e50723c7b7ff0af228c6711f7d747dd] Revert "net: cx82310_eth: use common match macro"
git bisect good 742c1c523e50723c7b7ff0af228c6711f7d747dd
# good: [175ff19c37149c352e3b983a8d78add034aef36f] tcp: fix tcp fin memory accounting
git bisect good 175ff19c37149c352e3b983a8d78add034aef36f
# first bad commit: [281c9c3601b69f1fbc492beb5976e1e2685854de] net: compat: Update get_compat_msghdr() to match copy_msghdr_from_user() behaviour
z00238152@Patch-Test:linux-3.10>0$
So, the problem commit is 281c9c36 (net: compat: Update get_compat_msghdr() to match copy_msghdr_from_user() behaviour), which fixes db31c55a6fb2
and brings the get_compat_msghdr() in line with copy_msghdr_from_user().
Cheers,
Junling
> thanks,
>
> greg k-h
>
> .
>
next prev parent reply other threads:[~2015-06-02 4:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 9:28 [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg Junling Zheng
2015-06-01 23:54 ` David Miller
2015-06-02 1:21 ` Greg KH
2015-06-02 4:05 ` Junling Zheng [this message]
2015-06-02 4:44 ` Greg KH
2015-06-02 6:19 ` Junling Zheng
2015-06-02 5:23 ` David Miller
2015-06-02 6:27 ` Greg KH
2015-06-02 6:43 ` Junling Zheng
2015-06-02 6:52 ` Willy Tarreau
2015-06-02 7:05 ` Junling Zheng
2015-06-02 10:15 ` Luis Henriques
2015-06-02 6:33 ` Junling Zheng
2015-06-02 6:27 ` Patch "net: socket: Fix the wrong returns for recvmsg and sendmsg" has been added to the 3.10-stable tree gregkh
2015-06-02 13:00 ` Patch "net: socket: Fix the wrong returns for recvmsg and sendmsg" has been added to the 3.14-stable tree gregkh
2015-08-01 19:36 ` [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556D2B8C.9010108@huawei.com \
--to=zhengjunling@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=lizefan@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=xuhanbing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox