From: Junling Zheng <zhengjunling@huawei•com>
To: David Miller <davem@davemloft•net>
Cc: <gregkh@linuxfoundation•org>, <lizefan@huawei•com>,
<viro@zeniv•linux.org.uk>, <xuhanbing@huawei•com>,
<stable@vger•kernel.org>, <netdev@vger•kernel.org>
Subject: Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg
Date: Tue, 2 Jun 2015 14:33:51 +0800 [thread overview]
Message-ID: <556D4E4F.5090609@huawei.com> (raw)
In-Reply-To: <20150601.222357.122000161676177828.davem@davemloft.net>
On 2015/6/2 13:23, David Miller wrote:
> From: Junling Zheng <zhengjunling@huawei•com>
> Date: Tue, 2 Jun 2015 12:05:32 +0800
>
>> So, the problem commit is 281c9c36 (net: compat: Update
>> get_compat_msghdr() to match copy_msghdr_from_user() behaviour),
>> which fixes db31c55a6fb2 and brings the get_compat_msghdr() in line
>> with copy_msghdr_from_user().
>
> Upstream this got fixed by:
>
> 08adb7dabd4874cc5666b4490653b26534702ce0
>
> So the part that makes us not unconditionally return -EFAULT needs
> to be backported, and that's probably equivalent to the patch
> your proposed which therefore should be applied.
>
> .
>
Yes, we indeed missed some changes of 08adb7d, and these changes could
make commit 281c9c36 appropriate for stable version.
In addition, I think other stable version also needs this fix.
Cheers,
Junling
next prev parent reply other threads:[~2015-06-02 6:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 9:28 [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg Junling Zheng
2015-06-01 23:54 ` David Miller
2015-06-02 1:21 ` Greg KH
2015-06-02 4:05 ` Junling Zheng
2015-06-02 4:44 ` Greg KH
2015-06-02 6:19 ` Junling Zheng
2015-06-02 5:23 ` David Miller
2015-06-02 6:27 ` Greg KH
2015-06-02 6:43 ` Junling Zheng
2015-06-02 6:52 ` Willy Tarreau
2015-06-02 7:05 ` Junling Zheng
2015-06-02 10:15 ` Luis Henriques
2015-06-02 6:33 ` Junling Zheng [this message]
2015-06-02 6:27 ` Patch "net: socket: Fix the wrong returns for recvmsg and sendmsg" has been added to the 3.10-stable tree gregkh
2015-06-02 13:00 ` Patch "net: socket: Fix the wrong returns for recvmsg and sendmsg" has been added to the 3.14-stable tree gregkh
2015-08-01 19:36 ` [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556D4E4F.5090609@huawei.com \
--to=zhengjunling@huawei$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=lizefan@huawei$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=xuhanbing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox