From: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
To: David Miller <davem@davemloft•net>
Cc: sfeldma@gmail•com, netdev@vger•kernel.org, jiri@resnulli•us,
simon.horman@netronome•com
Subject: Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops
Date: Tue, 02 Jun 2015 15:47:51 +0900 [thread overview]
Message-ID: <556D5197.2070300@lab.ntt.co.jp> (raw)
In-Reply-To: <20150601.222442.1854333703599698362.davem@davemloft.net>
On 2015/06/02 14:24, David Miller wrote:
> From: Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>
> Date: Tue, 02 Jun 2015 13:51:06 +0900
>
>> On 2015/06/02 3:39, sfeldma@gmail•com wrote:
>>> From: Scott Feldman <sfeldma@gmail•com>
>>>
>>> Remove support for legacy ndo ops
>>> .ndo_vlan_rx_add_vid/.ndo_vlan_rx_kill_vid. Rocker will use
>>> bridge_setlink/dellink exclusively for VLAN add/del operations.
>>>
>>> The legacy ops are needed if using 8021q driver module to setup VLANs on
>>> the port. But an alternative exists in using bridge_setlink/delink to
>>> setup VLANs, which doesn't depend on 8021q module. So rocker will switch
>>> to the newer setlink/dellink ops. VLANs can added/delete from the port,
>>> regardless if port is bridged or not, using the bridge commands:
>>>
>>> bridge vlan [add|del] vid VID dev DEV self
>>
>> Hi Scott,
>>
>> This doesn't look transparent with bridge.
>>
>> Before this patch, I was able to add vid in the same way as software bridge:
>>
>> ip link set DEV master br0
>> bridge vlan add vid VID dev DEV
>>
>> Now I need to add "self", which is different from software bridge...
>
> I'm already not liking the looks of this....
I thought one of purposes of implementing ndo_vlan_rx_add_vid() is to
make "bridge vlan add (master)" for bridged-ports work like software
bridges. Sorry if I misunderstood.
Toshiaki Makita
next prev parent reply other threads:[~2015-06-02 6:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 18:39 [PATCH net-next 0/5] rocker: enable by default untagged VLAN support sfeldma
2015-06-01 18:39 ` [PATCH net-next 1/5] rocker: zero allocate ports array sfeldma
2015-06-01 18:39 ` [PATCH net-next 2/5] rocker: cleanup vlan table on error adding vlan sfeldma
2015-06-01 18:39 ` [PATCH net-next 3/5] rocker: install untagged VLAN (vid=0) support for each port sfeldma
2015-06-01 18:39 ` [PATCH net-next 4/5] rocker: install/remove router MAC for untagged VLAN when joining/leaving bridge sfeldma
2015-06-01 18:39 ` [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops sfeldma
2015-06-02 4:51 ` Toshiaki Makita
2015-06-02 5:24 ` David Miller
2015-06-02 6:47 ` Toshiaki Makita [this message]
2015-06-02 7:10 ` Scott Feldman
2015-06-02 11:43 ` Jamal Hadi Salim
2015-06-02 14:30 ` Scott Feldman
2015-06-02 16:58 ` roopa
2015-06-02 19:01 ` Scott Feldman
2015-06-03 15:43 ` Toshiaki Makita
2015-06-03 18:41 ` roopa
2015-06-04 15:04 ` Toshiaki Makita
2015-06-04 15:09 ` roopa
2015-06-04 6:05 ` Scott Feldman
2015-06-04 14:35 ` Toshiaki Makita
2015-06-03 15:44 ` roopa
2015-06-03 12:08 ` Jamal Hadi Salim
2015-06-11 13:00 ` Jamal Hadi Salim
2015-06-11 18:25 ` Scott Feldman
2015-06-02 0:01 ` [PATCH net-next 0/5] rocker: enable by default untagged VLAN support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556D5197.2070300@lab.ntt.co.jp \
--to=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=davem@davemloft$(echo .)net \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox