From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Scott Feldman <sfeldma@gmail•com>
Cc: "David Miller" <davem@davemloft•net>,
"Toshiaki Makita" <makita.toshiaki@lab•ntt.co.jp>,
Netdev <netdev@vger•kernel.org>, "Jiří Pírko" <jiri@resnulli•us>,
"simon.horman@netronome•com" <simon.horman@netronome•com>
Subject: Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops
Date: Wed, 03 Jun 2015 08:08:39 -0400 [thread overview]
Message-ID: <556EEE47.6060002@mojatatu.com> (raw)
In-Reply-To: <CAE4R7bAXA27cqBLv6MP0kak-L=1bXUoZPw7vxUyYpP=-dk=eAg@mail.gmail.com>
On 06/02/15 10:30, Scott Feldman wrote:
> On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim <jhs@mojatatu•com> wrote:
>> On 06/02/15 03:10, Scott Feldman wrote:
>>
>> Question to ask when looking at something of this nature:
>> Will it work with no suprises if you used today's unmodified app?
>> The default behavior shouldnt change and unfortunately it does here.
>
> The default behavior does change, yes, but there shouldn't be any
> surprises even if using today's unmodified app.
[..]
[....]
>
> Ha, you're giving the behavior for "bridge fdb" command, where self is
> the default.
>
Yes, sorry ;->
> For "bridge link" and "bridge vlan", the default is master. The user
> must explicitly specify "self" to act on the device side of the port.
>
Not sure what "device side of the port" is intended to mean. But:
iproute2, user can specify device is either the bridge or bridge port.
I think that is the key.
This is used in combination with the self/master flags to decide
behavior in the kernel.
Summary, assuming flag bits master:self
user setting: 00 (none set - which is default iproute2 behavior).
Kernel behavior:
if (bridge port targeted)
sets the vlan bitmap on the bridge port.
else
sets the vlan bitmap on the bridge.
******* Above is what we want to maintain unchanged.
If you are saying it doesnt change, then we are fine.
user setting: 01 (self on)
kernel behavior: no difference from default
user setting: 1x (master on, self doesnt matter)
kernel behavior:
if (bridge port targeted)
sets the bitmap on the bridge port.
sets the bitmap on the bridge as well. <--------
else
sets the bitmap on the bridge.
BTW: given the vlan change are reflected from the bowels of
br_vlan_info() - is it redundant there is a call in br_afset
afterwards which says something like
"if master is set and target is bridge port then call hardware
setting thing"?
dont have much time - so i may be confusing something.
> It's unfortunate the iproute2 defaults aren't consistent between
> commands. Maybe someone knows the history here and can explain.
>
Not sure. Too many cooks with specific use cases? There are many
thing in bridge that i wish were different.
Unfortunately when things get to this level Dave's famous "a horse has
left the barn" principle applies. Despite my whining, over time,
even shit doesnt smell anymore. I almost feel we need an
ABI police force (refer to Jiri's talk at netconf).
It is much easier to fix kernel changes.
cheers,
jamal
next prev parent reply other threads:[~2015-06-03 12:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 18:39 [PATCH net-next 0/5] rocker: enable by default untagged VLAN support sfeldma
2015-06-01 18:39 ` [PATCH net-next 1/5] rocker: zero allocate ports array sfeldma
2015-06-01 18:39 ` [PATCH net-next 2/5] rocker: cleanup vlan table on error adding vlan sfeldma
2015-06-01 18:39 ` [PATCH net-next 3/5] rocker: install untagged VLAN (vid=0) support for each port sfeldma
2015-06-01 18:39 ` [PATCH net-next 4/5] rocker: install/remove router MAC for untagged VLAN when joining/leaving bridge sfeldma
2015-06-01 18:39 ` [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops sfeldma
2015-06-02 4:51 ` Toshiaki Makita
2015-06-02 5:24 ` David Miller
2015-06-02 6:47 ` Toshiaki Makita
2015-06-02 7:10 ` Scott Feldman
2015-06-02 11:43 ` Jamal Hadi Salim
2015-06-02 14:30 ` Scott Feldman
2015-06-02 16:58 ` roopa
2015-06-02 19:01 ` Scott Feldman
2015-06-03 15:43 ` Toshiaki Makita
2015-06-03 18:41 ` roopa
2015-06-04 15:04 ` Toshiaki Makita
2015-06-04 15:09 ` roopa
2015-06-04 6:05 ` Scott Feldman
2015-06-04 14:35 ` Toshiaki Makita
2015-06-03 15:44 ` roopa
2015-06-03 12:08 ` Jamal Hadi Salim [this message]
2015-06-11 13:00 ` Jamal Hadi Salim
2015-06-11 18:25 ` Scott Feldman
2015-06-02 0:01 ` [PATCH net-next 0/5] rocker: enable by default untagged VLAN support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556EEE47.6060002@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jiri@resnulli$(echo .)us \
--cc=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
--cc=simon.horman@netronome$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox