From: Josh Hunt <johunt@akamai•com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>,
Hajime Tazaki <thehajime@gmail•com>,
davem@davemloft•net
Cc: kuznet@ms2•inr.ac.ru, jmorris@namei•org, kaber@trash•net,
netdev@vger•kernel.org, sergei.shtylyov@cogentembedded•com,
tom@herbertland•com
Subject: Re: [PATCH v3] ipv6: Fix protocol resubmission
Date: Wed, 10 Jun 2015 10:53:32 -0500 [thread overview]
Message-ID: <55785D7C.7080505@akamai.com> (raw)
In-Reply-To: <55785687.90601@akamai.com>
On 06/10/2015 10:23 AM, Josh Hunt wrote:
> On 06/10/2015 10:16 AM, YOSHIFUJI Hideaki wrote:
>> Hi,
>>
>> Josh Hunt wrote:
>>>
>>> Hajime
>>>
>>> Thanks for the report. I mentioned in an earlier post this might be a
>>> problem.
>>>
>>> Dave, what if we restore the old behavior, but add a new label to
>>> handle the case where the decapsulating protocol returns the nexthdr
>>> value? Allowing for migration over to this method over time. I've
>>> pasted in a patch doing so below.
>>
>> I think it is insufficient because IPv6 stack already uses
>> positive value, 0 and negative values.
>>
>
> Where does it use a negative value?
>
> ret is only checked to be > or == to 0. I don't see any checks or code
> handling a return value of < 0 prior to my patch.
>
> If something does return a negative value should it since nothing
> happens with it?
Looking at the code again, I guess we don't increment
IPSTATS_MIB_INDELIVERS if we get a negative return value prior to my patch.
If so, then I guess we have to fix this in the udp path like you were
suggesting. I will look at this and propose a patch to revert my
original change and update the v6 udp code.
Josh
next prev parent reply other threads:[~2015-06-10 15:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 16:00 [PATCH v3] ipv6: Fix protocol resubmission Josh Hunt
2015-06-08 16:10 ` Tom Herbert
2015-06-08 19:16 ` David Miller
2015-06-10 4:24 ` Hajime Tazaki
2015-06-10 4:53 ` YOSHIFUJI Hideaki
2015-06-10 13:22 ` Josh Hunt
2015-06-10 15:16 ` YOSHIFUJI Hideaki
2015-06-10 15:23 ` Josh Hunt
2015-06-10 15:53 ` Josh Hunt [this message]
2015-06-10 21:57 ` Josh Hunt
2015-06-10 22:30 ` David Miller
2015-06-11 13:05 ` Hajime Tazaki
2015-06-11 15:32 ` Josh Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55785D7C.7080505@akamai.com \
--to=johunt@akamai$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=thehajime@gmail$(echo .)com \
--cc=tom@herbertland$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox