From: Josh Hunt <johunt@akamai•com>
To: davem@davemloft•net
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>,
Hajime Tazaki <thehajime@gmail•com>,
kuznet@ms2•inr.ac.ru, jmorris@namei•org, kaber@trash•net,
netdev@vger•kernel.org, sergei.shtylyov@cogentembedded•com,
tom@herbertland•com
Subject: Re: [PATCH v3] ipv6: Fix protocol resubmission
Date: Wed, 10 Jun 2015 16:57:25 -0500 [thread overview]
Message-ID: <5578B2C5.7080202@akamai.com> (raw)
In-Reply-To: <557854BB.1090605@linux-ipv6.org>
On 06/10/2015 10:16 AM, YOSHIFUJI Hideaki wrote:
> Hi,
>
> Josh Hunt wrote:
>> On 06/09/2015 11:24 PM, Hajime Tazaki wrote:
>>>
>>> Hello Josh, Dave,
>>>
>>> my mobile ipv6 test on libos failed with this commit.
>>>
>>> This commit makes a destination option header handling (i.e.,
>>> ipprot->handler == ipv6_destopt_rcv) failed since
>>> ipv6_destopt_rcv() seems to return a positive value to
>>> indicate to goto resubmission label.
>>>
>>> I will look for more detail.
>>>
>>> -- Hajime
>>
>> Hajime
>>
>> Thanks for the report. I mentioned in an earlier post this might be a problem.
>>
>> Dave, what if we restore the old behavior, but add a new label to handle the case where the decapsulating protocol returns the nexthdr value? Allowing for migration over to this method over time. I've pasted in a patch doing so below.
>
> I think it is insufficient because IPv6 stack already uses
> positive value, 0 and negative values.
>
>>
>> The other solution I guess is to change how the udp handler works, but I was hoping to keep it behaving the same as v4.
>
> xfrm returns different value for IPv4 and IPv6, for example,
> so udp can do in the same way. And we can use the fact that
> the size of next header field is 8-bit.
>
Dave
Can you please revert this change?
commit 0243508edd317ff1fa63b495643a7c192fbfcd92
Author: Josh Hunt <johunt@akamai•com>
Date: Mon Jun 8 12:00:59 2015 -0400
ipv6: Fix protocol resubmission
Let me know if you need a patch to do this and I will submit something.
I will fix the original issue in the UDP code in another patch.
Josh
next prev parent reply other threads:[~2015-06-10 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 16:00 [PATCH v3] ipv6: Fix protocol resubmission Josh Hunt
2015-06-08 16:10 ` Tom Herbert
2015-06-08 19:16 ` David Miller
2015-06-10 4:24 ` Hajime Tazaki
2015-06-10 4:53 ` YOSHIFUJI Hideaki
2015-06-10 13:22 ` Josh Hunt
2015-06-10 15:16 ` YOSHIFUJI Hideaki
2015-06-10 15:23 ` Josh Hunt
2015-06-10 15:53 ` Josh Hunt
2015-06-10 21:57 ` Josh Hunt [this message]
2015-06-10 22:30 ` David Miller
2015-06-11 13:05 ` Hajime Tazaki
2015-06-11 15:32 ` Josh Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5578B2C5.7080202@akamai.com \
--to=johunt@akamai$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@namei$(echo .)org \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=thehajime@gmail$(echo .)com \
--cc=tom@herbertland$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox