From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Andy Gospodarek <gospo@cumulusnetworks•com>, netdev@vger•kernel.org
Subject: Re: [PATCH net-next v2] ipv4: add support for linkdown sysctl to netconf
Date: Wed, 08 Jul 2015 11:43:50 +0200 [thread overview]
Message-ID: <559CF0D6.3090602@6wind.com> (raw)
In-Reply-To: <1436291817-1555-1-git-send-email-gospo@cumulusnetworks.com>
Le 07/07/2015 19:56, Andy Gospodarek a écrit :
> This kernel patch exports the value of the new
> ignore_routes_with_linkdown via netconf.
>
> v2: changes to notify userspace via netlink when sysctl values change
> and proposed for 'net' since this could be considered a bugfix
Hmm, commit title contains net-next, not net.
>
> Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks•com>
> Suggested-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
> ---
> I realize two of these changes result in lines >80 chars, but this is to
> keep the coding-style used by the surrounding code.
>
> There are multiple ways to resolve this, but one would be to shorten the
> defines used for this feature as "IGNORE_ROUTES_WITH_LINKDOWN" is a
> mouthful. I would propose dropping "_WITH_" from all the defines and
> have only "IGNORE_ROUTES_LINKDOWN" everywhere. Doing this now in 'net'
Yes. Or even shorter: IGNORE_NH_LINKDOWN?
> would be ideal before a release happens and it cannot be changed.
Yes.
next prev parent reply other threads:[~2015-07-08 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 17:56 [PATCH net-next v2] ipv4: add support for linkdown sysctl to netconf Andy Gospodarek
2015-07-08 9:43 ` Nicolas Dichtel [this message]
2015-07-08 12:42 ` Andy Gospodarek
2015-07-09 6:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559CF0D6.3090602@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox