From: David Ahern <dsa@cumulusnetworks•com>
To: Thomas Graf <tgraf@suug•ch>
Cc: netdev@vger•kernel.org, shm@cumulusnetworks•com
Subject: Re: [PATCH net-next] inetpeer: Add support for VRFs
Date: Sun, 23 Aug 2015 20:01:34 -0600 [thread overview]
Message-ID: <55DA7AFE.5040301@cumulusnetworks.com> (raw)
In-Reply-To: <20150824001514.GD21926@pox.localdomain>
On 8/23/15 6:15 PM, Thomas Graf wrote:
> On 08/23/15 at 08:26am, David Ahern wrote:
>> inetpeer caches based on address only, so duplicate IP addresses within
>> a namespace return the same cached entry. Similar to IP fragments handle
>> duplicate addresses across VRFs by adding the VRF master device index to
>> the lookup.
>
> We have a lot of other places which use the address only. Are you
> going to add the VRF id to all these places as well?
>
If appropriate, yes. I have fixed IP fragments and this patch fixes
inetpeer cache. In both cases (L3 artifacts) the vrf device index
provides the means to uniquely identify duplicate IP addresses within a
namespace. If you know of other code that might be impacted I will
investigate and fix as needed.
Thanks,
David
next prev parent reply other threads:[~2015-08-24 2:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 14:26 [PATCH net-next] inetpeer: Add support for VRFs David Ahern
2015-08-24 0:15 ` Thomas Graf
2015-08-24 2:01 ` David Ahern [this message]
2015-08-25 17:37 ` Thomas Graf
2015-08-25 20:47 ` David Miller
2015-08-25 22:41 ` David Ahern
2015-08-25 22:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DA7AFE.5040301@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox