From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Xin Long <lucien.xin@gmail•com>, network dev <netdev@vger•kernel.org>
Cc: mleitner@redhat•com, davem@davemloft•net
Subject: Re: [PATCH net] sctp: asconf's process should verify address parameter is in the beginning
Date: Mon, 24 Aug 2015 15:13:03 +0300 [thread overview]
Message-ID: <55DB0A4F.8090004@cogentembedded.com> (raw)
In-Reply-To: <87d339ea910a3665c9376b6ba69b003af967c6d1.1440410878.git.lucien.xin@gmail.com>
Hello.
On 8/24/2015 1:07 PM, Xin Long wrote:
> in sctp_process_asconf(), we get address parameter from the beginning of the
> addip params. but we never check if it's really there. if the addr param is not
> there, it still can pass sctp_verify_asconf(), then to be handled by
> sctp_process_asconf(), it will not be safe.
>
> so add a code in sctp_verify_asconf() to check the address parameter is in the
> beginning, or return false to send abort.
>
> Signed-off-by: Xin Long <lucien.xin@gmail•com>
> ---
> net/sctp/sm_make_chunk.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
> index 0ee5ca7..a2a72d5 100644
> --- a/net/sctp/sm_make_chunk.c
> +++ b/net/sctp/sm_make_chunk.c
> @@ -3122,6 +3122,14 @@ bool sctp_verify_asconf(const struct sctp_association *asoc,
> union sctp_params param;
> bool addr_param_seen = false;
>
> + if(addr_param_needed){
Space needed after *if*. Please run your patches thru
scripts/checkpatch.pl before posting.
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-08-24 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 10:07 [PATCH net] sctp: asconf's process should verify address parameter is in the beginning Xin Long
2015-08-24 12:13 ` Sergei Shtylyov [this message]
2015-08-24 17:33 ` Vlad Yasevich
2015-08-25 12:28 ` lucien xin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DB0A4F.8090004@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=lucien.xin@gmail$(echo .)com \
--cc=mleitner@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox