public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: roopa <roopa@cumulusnetworks•com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
Cc: David Miller <davem@davemloft•net>,
	netdev@vger•kernel.org, vyasevic@redhat•com,
	toshiaki.makita1@gmail•com, stephen@networkplumber•org,
	bridge@lists•linux-foundation.org, wkok@cumulusnetworks•com
Subject: Re: [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans
Date: Wed, 26 Aug 2015 21:57:19 -0700	[thread overview]
Message-ID: <55DE98AF.8000503@cumulusnetworks.com> (raw)
In-Reply-To: <AB16F445-DCA7-437E-B6E1-B70FDC63E55A@cumulusnetworks.com>

On 8/26/15, 4:33 AM, Nikolay Aleksandrov wrote:
>> On Aug 25, 2015, at 11:06 PM, David Miller <davem@davemloft•net> wrote:
>>
>> From: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
>> Date: Tue, 25 Aug 2015 22:28:16 -0700
>>
>>> Certainly, that should be done and I will look into it, but the
>>> essence of this patch is a bit different. The problem here is not
>>> the size of the fdb entries, it’s more the number of them - having
>>> 96000 entries (even if they were 1 byte ones) is just way too much
>>> especially when the fdb hash size is small and static. We could work
>>> on making it dynamic though, but still these type of local entries
>>> per vlan per port can easily be avoided with this option.
>> 96000 bits can be stored in 12k.  Get where I'm going with this?
>>
>> Look at the problem sideways.
> Oh okay, I misunderstood your previous comment. I’ll look into that.
>
I just wanted to add the other problems we have had with keeping these 
macs (mostly from userspace POV):
- add/del netlink notification storms
- and large netlink dumps

In addition to in-kernel optimizations, will be nice to have a solution 
that reduces the burden on userspace. That will need a newer netlink 
dump format for fdbs. Considering all the changes needed, Nikolays patch 
seems less intrusive.

  reply	other threads:[~2015-08-27  4:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26  0:34 [PATCH net-next v2] bridge: vlan: allow to suppress local mac install for all vlans Nikolay Aleksandrov
2015-08-26  0:56 ` Stephen Hemminger
2015-08-26  5:42   ` Nikolay Aleksandrov
2015-08-26  0:58 ` Stephen Hemminger
2015-08-26  2:42 ` David Miller
2015-08-26  5:28   ` Nikolay Aleksandrov
2015-08-26  6:06     ` David Miller
2015-08-26 11:33       ` Nikolay Aleksandrov
2015-08-27  4:57         ` roopa [this message]
2015-08-27 21:02           ` Nikolay Aleksandrov
2015-08-27 23:47             ` Vlad Yasevich
2015-08-28  2:17               ` Nikolay Aleksandrov
2015-08-28 12:31                 ` Vlad Yasevich
2015-08-28 15:26                   ` Nikolay Aleksandrov
2015-08-29  1:11                     ` Vlad Yasevich
2015-09-13 13:22                       ` Nikolay Aleksandrov
2015-08-26  6:10     ` B Viswanath
2015-08-26 12:52       ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DE98AF.8000503@cumulusnetworks.com \
    --to=roopa@cumulusnetworks$(echo .)com \
    --cc=bridge@lists$(echo .)linux-foundation.org \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=nikolay@cumulusnetworks$(echo .)com \
    --cc=stephen@networkplumber$(echo .)org \
    --cc=toshiaki.makita1@gmail$(echo .)com \
    --cc=vyasevic@redhat$(echo .)com \
    --cc=wkok@cumulusnetworks$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox