From: David Ahern <dsa@cumulusnetworks•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org
Subject: Re: [RFC PATCH net-next 0/3] L3 RX handler
Date: Sat, 29 Aug 2015 08:05:45 -0700 [thread overview]
Message-ID: <55E1CA49.9040803@cumulusnetworks.com> (raw)
In-Reply-To: <20150828.221404.100480720904987645.davem@davemloft.net>
On 8/28/15 10:14 PM, David Miller wrote:
> From: David Ahern <dsa@cumulusnetworks•com>
> Date: Fri, 28 Aug 2015 17:34:20 -0700
>
>> Currently the VRF driver registers an Rx handler for enslaved devices.
>> The handler switches the skb->dev to the VRF device and sends it back for
>> another pass. While this works fine a side effect is that it bypasses
>> netfilter with the skb set to the original device.
>>
>> Looking at how to provide that feature a few options come to mind:
>> 1. Have the rx handler in the VRF driver duplicate some of the processing
>> of ip_rcv up to the NF_HOOK and then switch the skb->dev to vrf device.
>>
>> 2. Run NF_HOOK in ip_rcv twice -- once with orig_dev and then again for dev.
>>
>> 3. Introduce an L3 rx-handler that provides the option of hooking packets
>> at L3 rather than the current backlog loop.
>>
>> This RFC looks at option 3. I wanted to get opinions on the approach
>> versus other options.
>
> No way, this is not going to pass.
I'll drop this option. Thanks for the quick response.
prev parent reply other threads:[~2015-08-29 15:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 0:34 [RFC PATCH net-next 0/3] L3 RX handler David Ahern
2015-08-29 0:34 ` [RFC PATCH net-next 1/3] net: Introduce L3 RX Handler David Ahern
2015-08-29 0:34 ` [RFC PATCH net-next 2/3] net: Add L3 Rx handler to IPv4 processing David Ahern
2015-08-29 0:34 ` [RFC PATCH net-next 3/3] net: Change VRF driver to use the new L3 RX handler David Ahern
2015-08-29 1:31 ` [RFC PATCH net-next 0/3] " Eric Dumazet
2015-08-29 5:14 ` David Miller
2015-08-29 15:20 ` David Ahern
2015-08-29 18:02 ` Tom Herbert
2015-08-31 3:59 ` David Ahern
2015-08-29 5:14 ` David Miller
2015-08-29 15:05 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E1CA49.9040803@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox