From: David Ahern <dsa@cumulusnetworks•com>
To: Tom Herbert <tom@herbertland•com>
Cc: David Miller <davem@davemloft•net>,
Eric Dumazet <eric.dumazet@gmail•com>,
Linux Kernel Network Developers <netdev@vger•kernel.org>,
Shrijeet Mukherjee <shm@cumulusnetworks•com>
Subject: Re: [RFC PATCH net-next 0/3] L3 RX handler
Date: Sun, 30 Aug 2015 21:59:23 -0600 [thread overview]
Message-ID: <55E3D11B.9050303@cumulusnetworks.com> (raw)
In-Reply-To: <CALx6S37JNtd-+A0pCTGGq=4oj_YoVHc0XZpX-tPzv9L8YvmGyg@mail.gmail.com>
Hi Tom:
On 8/29/15 12:02 PM, Tom Herbert wrote:
> To begin with, can we abstract out the need for common code to know
> about the VRF device (netif_index_is_vrf). Looking more closely at
> udp_semdmsg code, there's seems to be some potential problems:
My intention to address your udp_sendmsg comment is to rip out the
change that was added and set the source address in the VRF device
driver. Doing so ...
>
> 1) In the VRF case route lookup is being called twice for every
> unconnected packet when going through vrf path :-(
> 2) The "unconnected socket" comment is not incorrect, this path is
> taken for connected sockets also before there is a cache route
> 3) Looks like in VRF path the source address can be arbitrarily
> overwritten in the case that it is non-zero (that is non-zero, but not
> a connect socket).
... fixes the above problems for non-VRF users completely. VRF users
will still have multiple lookups but that is by design.
David
next prev parent reply other threads:[~2015-08-31 3:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 0:34 [RFC PATCH net-next 0/3] L3 RX handler David Ahern
2015-08-29 0:34 ` [RFC PATCH net-next 1/3] net: Introduce L3 RX Handler David Ahern
2015-08-29 0:34 ` [RFC PATCH net-next 2/3] net: Add L3 Rx handler to IPv4 processing David Ahern
2015-08-29 0:34 ` [RFC PATCH net-next 3/3] net: Change VRF driver to use the new L3 RX handler David Ahern
2015-08-29 1:31 ` [RFC PATCH net-next 0/3] " Eric Dumazet
2015-08-29 5:14 ` David Miller
2015-08-29 15:20 ` David Ahern
2015-08-29 18:02 ` Tom Herbert
2015-08-31 3:59 ` David Ahern [this message]
2015-08-29 5:14 ` David Miller
2015-08-29 15:05 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E3D11B.9050303@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shm@cumulusnetworks$(echo .)com \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox