From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: roopa <roopa@cumulusnetworks•com>
Cc: davem@davemloft•net, Mazziesaccount@gmail•com,
hannes@stressinduktion•org, kuznet@ms2•inr.ac.ru,
jmorris@namei•org, yoshfuji@linux-ipv6•org,
netdev@vger•kernel.org, Michal Kubecek <mkubecek@suse•cz>
Subject: Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery
Date: Mon, 7 Sep 2015 14:03:12 +0200 [thread overview]
Message-ID: <55ED7D00.3050202@6wind.com> (raw)
In-Reply-To: <55ECA62F.9070905@cumulusnetworks.com>
+ Michal Kubecek
Le 06/09/2015 22:46, roopa a écrit :
> On 9/4/15, 1:12 AM, Nicolas Dichtel wrote:
>> Le 03/09/2015 01:44, Roopa Prabhu a écrit :
[snip]
>>> Fixes: 4a287eba2de3 ("IPv6 routing, NLM_F_* flag support: REPLACE and EXCL
>>> flags support, warn about missing CREATE flag")
>> ECMP was added one year after this patch. The right tag is:
>> Fixes: 51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)")
> I went back and looked again. It is a recent one 27596472473a ("ipv6: fix ECMP
> route replacement").
The bug you're trying to fix has been introduced by the commit 51ebd3181572
("ipv6: add support of equal cost multipath (ECMP)").
Commit 27596472473a ("ipv6: fix ECMP route replacement") didn't try to fix this
problem.
Note that the first patch you submitted to fix this pb (cf
http://patchwork.ozlabs.org/patch/362296/) was in June 2014, ie one year before
the commit 27596472473a.
Regards,
Nicolas
next prev parent reply other threads:[~2015-09-07 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 23:44 [PATCH net-next v2] ipv6: fix multipath route replace error recovery Roopa Prabhu
2015-09-04 8:12 ` Nicolas Dichtel
2015-09-06 20:46 ` roopa
2015-09-07 12:03 ` Nicolas Dichtel [this message]
2015-09-08 0:01 ` roopa
2015-09-08 9:33 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ED7D00.3050202@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=Mazziesaccount@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hannes@stressinduktion$(echo .)org \
--cc=jmorris@namei$(echo .)org \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=roopa@cumulusnetworks$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox