public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Thomas F Herbert <thomasfherbert@gmail•com>,
	netdev@vger•kernel.org, pshelar@nicira•com
Cc: therbert@redhat•com, dev@openvswitch•org
Subject: Re: [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad
Date: Thu, 15 Oct 2015 17:05:14 +0300	[thread overview]
Message-ID: <561FB29A.4080101@cogentembedded.com> (raw)
In-Reply-To: <1444917715-27093-3-git-send-email-thomasfherbert@gmail.com>

On 10/15/2015 5:01 PM, Thomas F Herbert wrote:

    Hm, I'm seeing no sign-off on this patch.

> ---
>   include/linux/if_vlan.h | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
> index 67ce5bd..ac23521 100644
> --- a/include/linux/if_vlan.h
> +++ b/include/linux/if_vlan.h
> @@ -627,6 +627,22 @@ static inline netdev_features_t vlan_features_check(const struct sk_buff *skb,
>
>   	return features;
>   }
> +/**
> + * eth_type_vlan - check for valid vlan ether type.
> + * @ethertype: ether type to check
> + *
> + * Returns true if the ether type is a vlan ether type.
> + */
> +static inline bool eth_type_vlan(__be16 ethertype)
> +{
> +	switch (ethertype) {
> +	case (htons(ETH_P_8021Q)):
> +	case (htons(ETH_P_8021AD)):

    Hm, I thought you had a request to delete the outer parens already...

[...]

MBR, Sergei

  reply	other threads:[~2015-10-15 14:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 14:01 [PATCH net-next V16 0/3] openvswitch: Add support for 802.1ad Thomas F Herbert
2015-10-15 14:01 ` [PATCH net-next V16 1/3] openvswitch: 802.1ad uapi changes Thomas F Herbert
2015-10-15 14:01 ` [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad Thomas F Herbert
2015-10-15 14:05   ` Sergei Shtylyov [this message]
2015-10-15 14:01 ` [PATCH net-next V16 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes Thomas F Herbert
2015-10-15 23:02   ` Pravin Shelar
     [not found]     ` <CALnjE+o4o1RWf12F9wyeZfb9=Y+nw+Bta=NA+we1zQ+4yGLYNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-15 23:48       ` Thomas F Herbert
     [not found]         ` <56203B38.2040806-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-16  0:37           ` Pravin Shelar
2015-10-16  2:03             ` Thomas F Herbert
2015-10-16  6:16 ` [PATCH net-next V16 0/3] openvswitch: Add support for 802.1ad David Miller
     [not found]   ` <20151015.231643.799590798559891150.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-10-16 10:59     ` Thomas F Herbert
  -- strict thread matches above, loose matches on Subject: below --
2015-10-15 14:36 [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad Thomas F Herbert
2015-10-15 17:19 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561FB29A.4080101@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded$(echo .)com \
    --cc=dev@openvswitch$(echo .)org \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pshelar@nicira$(echo .)com \
    --cc=therbert@redhat$(echo .)com \
    --cc=thomasfherbert@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox