From: Or Gerlitz <ogerlitz@mellanox•com>
To: Andrzej Hajda <a.hajda@samsung•com>
Cc: Jack Morgenstein <jackm@dev•mellanox.co.il>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>,
Marek Szyprowski <m.szyprowski@samsung•com>,
"David S. Miller" <davem@davemloft•net>,
Eran Ben Elisha <eranbe@mellanox•com>,
Hadar Hen Zion <hadarh@mellanox•com>,
Moni Shoua <monis@mellanox•com>,
Yishai Hadas <yishaih@mellanox•com>,
Maor Gottlieb <maorg@mellanox•com>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>
Subject: Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port
Date: Tue, 15 Dec 2015 11:09:40 +0200 [thread overview]
Message-ID: <566FD8D4.5030506@mellanox.com> (raw)
In-Reply-To: <1450087564-28441-1-git-send-email-a.hajda@samsung.com>
On 12/14/2015 12:05 PM, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
Please add here
Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF')
> Signed-off-by: Andrzej Hajda <a.hajda@samsung•com>
otherwise, Looks good
Acked-by: Or Gerlitz <ogerlitz@mellanox•com>
Or.
next prev parent reply other threads:[~2015-12-15 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 10:05 [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port Andrzej Hajda
2015-12-14 10:06 ` [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate Andrzej Hajda
[not found] ` <1450087564-28441-4-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-12-31 13:12 ` Kalle Valo
2015-12-15 9:09 ` Or Gerlitz [this message]
2015-12-15 16:55 ` [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566FD8D4.5030506@mellanox.com \
--to=ogerlitz@mellanox$(echo .)com \
--cc=a.hajda@samsung$(echo .)com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eranbe@mellanox$(echo .)com \
--cc=hadarh@mellanox$(echo .)com \
--cc=jackm@dev$(echo .)mellanox.co.il \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=maorg@mellanox$(echo .)com \
--cc=monis@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yishaih@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox