From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public•gmane.org>
To: Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public•gmane.org>,
'Faisal Latif'
<faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>
Cc: 'Or Gerlitz' <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public•gmane.org>,
'Doug Ledford' <dledford-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>,
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
'Linux Netdev List'
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
'Jeff Kirsher'
<jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public•gmane.org>,
<e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public•gmane.org>
Subject: Re: [PATCH v3 00/16] add Intel X722 iWARP driver
Date: Thu, 21 Jan 2016 09:53:51 +0200 [thread overview]
Message-ID: <56A08E8F.7090602@mellanox.com> (raw)
In-Reply-To: <00cf01d153d5$e6248eb0$b26dac10$@opengridcomputing.com>
On 1/21/2016 12:57 AM, Steve Wise wrote:
> I also asked you why the port mapper code has to be present in each
> iwarp driver and not part of the IB core stack, and you responded
> "i40iw iwarp driver registers with port mapper and uses its services.
> Beside that it is not the scope of the patch series" -- well, it is
> in the scope of upstream review to pose such questions, please
> address.
>
>
> There is a common service/API in the IB core for iWarp port mapping. See drivers/infinbiand/core/iwpm*.c and include/rdma/iw_portmap.h.
>
>
Steve,
Okay, but I still don't follow why each vendor needs an RDMA_NL_YYY ID
(RDMA_NL_C4IW, RDMA_NL_NES and now a new one for this driver) of their own.
I see that the two current drivers actually use the same callbacks
towards user-space, does each vendor uses a different user-space daemon,
why?
Or.
net.git]# cd drivers/infiniband/hw/
hw]# git grep RDMA_NL_IWPM .
cxgb4/device.c: [RDMA_NL_IWPM_REG_PID] = {.dump = iwpm_register_pid_cb},
cxgb4/device.c: [RDMA_NL_IWPM_ADD_MAPPING] = {.dump = iwpm_add_mapping_cb},
cxgb4/device.c: [RDMA_NL_IWPM_QUERY_MAPPING] = {.dump =
iwpm_add_and_query_mapping_cb},
cxgb4/device.c: [RDMA_NL_IWPM_HANDLE_ERR] = {.dump = iwpm_mapping_error_cb},
cxgb4/device.c: [RDMA_NL_IWPM_REMOTE_INFO] = {.dump = iwpm_remote_info_cb},
cxgb4/device.c: [RDMA_NL_IWPM_MAPINFO] = {.dump = iwpm_mapping_info_cb},
cxgb4/device.c: [RDMA_NL_IWPM_MAPINFO_NUM] = {.dump =
iwpm_ack_mapping_info_cb}
cxgb4/device.c: if (ibnl_add_client(RDMA_NL_C4IW, RDMA_NL_IWPM_NUM_OPS,
nes/nes.c: [RDMA_NL_IWPM_REG_PID] = {.dump = iwpm_register_pid_cb},
nes/nes.c: [RDMA_NL_IWPM_ADD_MAPPING] = {.dump = iwpm_add_mapping_cb},
nes/nes.c: [RDMA_NL_IWPM_QUERY_MAPPING] = {.dump =
iwpm_add_and_query_mapping_cb},
nes/nes.c: [RDMA_NL_IWPM_REMOTE_INFO] = {.dump = iwpm_remote_info_cb},
nes/nes.c: [RDMA_NL_IWPM_HANDLE_ERR] = {.dump = iwpm_mapping_error_cb},
nes/nes.c: [RDMA_NL_IWPM_MAPINFO] = {.dump = iwpm_mapping_info_cb},
nes/nes.c: [RDMA_NL_IWPM_MAPINFO_NUM] = {.dump =
iwpm_ack_mapping_info_cb}
nes/nes.c: if (ibnl_add_client(RDMA_NL_NES, RDMA_NL_IWPM_NUM_OPS,
nes_nl_cb_table))
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-21 7:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 19:40 [PATCH v3 00/16] add Intel X722 iWARP driver Faisal Latif
2016-01-20 19:40 ` [PATCH v3 04/16] i40iw: add connection management code Faisal Latif
[not found] ` <1453318816-21672-1-git-send-email-faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-20 19:40 ` [PATCH v3 01/16] i40e: Add support for client interface for IWARP driver Faisal Latif
2016-01-20 19:40 ` [PATCH v3 02/16] i40iw: add entry in rdma_netlink Faisal Latif
2016-01-20 19:40 ` [PATCH v3 03/16] i40iw: add main, hdr, status Faisal Latif
2016-01-20 19:40 ` [PATCH v3 05/16] i40iw: add puda code Faisal Latif
2016-01-20 19:40 ` [PATCH v3 07/16] i40iw: add hmc resource files Faisal Latif
2016-01-20 19:40 ` [PATCH v3 08/16] i40iw: add hw and utils files Faisal Latif
2016-01-20 19:40 ` [PATCH v3 11/16] i40iw: add hardware related header files Faisal Latif
2016-01-20 19:40 ` [PATCH v3 13/16] i40iw: user kernel shared files Faisal Latif
2016-01-20 22:24 ` [PATCH v3 00/16] add Intel X722 iWARP driver Or Gerlitz
2016-01-20 22:57 ` Steve Wise
2016-01-21 7:53 ` Or Gerlitz [this message]
[not found] ` <56A08E8F.7090602-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-01-21 15:32 ` Steve Wise
2016-01-21 17:05 ` Or Gerlitz
[not found] ` <56A10FEC.5020402-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-01-21 18:24 ` Faisal Latif
2016-01-21 18:40 ` Or Gerlitz
[not found] ` <CAJ3xEMgE1-EuNBmYVfLoBwjohcxt5tio6wtZn=TYvDAgQgh9cw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-21 19:21 ` David Miller
2016-04-04 7:39 ` Christoph Hellwig
[not found] ` <20160404073929.GA23218-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-04 17:59 ` Faisal Latif
2016-01-20 19:40 ` [PATCH v3 06/16] i40iw: add pble resource files Faisal Latif
2016-01-20 19:40 ` [PATCH v3 09/16] i40iw: add files for iwarp interface Faisal Latif
2016-01-20 19:40 ` [PATCH v3 10/16] i40iw: add file to handle cqp calls Faisal Latif
2016-01-20 19:40 ` [PATCH v3 12/16] i40iw: add X722 register file Faisal Latif
2016-01-20 19:40 ` [PATCH v3 14/16] i40iw: virtual channel handling files Faisal Latif
2016-01-20 19:40 ` [PATCH v3 15/16] i40iw: Kconfig and Makefile for iwarp module Faisal Latif
2016-01-20 19:40 ` [PATCH v3 16/16] i40iw: changes for build of i40iw module Faisal Latif
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A08E8F.7090602@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public$(echo .)gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public$(echo .)gmane.org \
--cc=faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public$(echo .)gmane.org \
--cc=jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public$(echo .)gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox