* [PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid'
@ 2016-02-03 0:53 Roopa Prabhu
2016-02-03 8:20 ` Nicolas Dichtel
2016-02-05 0:48 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Roopa Prabhu @ 2016-02-03 0:53 UTC (permalink / raw)
To: stephen; +Cc: netdev, nicolas.dichtel
From: Roopa Prabhu <roopa@cumulusnetworks•com>
'ip monitor all' is broken on older kernels.
This patch fixes 'ip monitor all' to match
'all' and not 'all-nsid'.
It moves parsing arg 'all-nsid' to after parsing
'all'.
Before:
$ip monitor all
NETLINK_LISTEN_ALL_NSID: Protocol not available
After:
$ip monitor all
[NEIGH]Deleted 10.0.0.1 dev eth1 lladdr c4:54:44:4f:b2:dd STALE
Fixes: 449b824ad196 ("ipmonitor: allows to monitor in several netns")
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks•com>
---
ip/ipmonitor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ip/ipmonitor.c b/ip/ipmonitor.c
index 99a237f..7aeccd2 100644
--- a/ip/ipmonitor.c
+++ b/ip/ipmonitor.c
@@ -186,8 +186,6 @@ int do_ipmonitor(int argc, char **argv)
file = *argv;
} else if (matches(*argv, "label") == 0) {
prefix_banner = 1;
- } else if (matches(*argv, "all-nsid") == 0) {
- listen_all_nsid = 1;
} else if (matches(*argv, "link") == 0) {
llink=1;
groups = 0;
@@ -217,6 +215,8 @@ int do_ipmonitor(int argc, char **argv)
groups = 0;
} else if (strcmp(*argv, "all") == 0) {
prefix_banner=1;
+ } else if (matches(*argv, "all-nsid") == 0) {
+ listen_all_nsid = 1;
} else if (matches(*argv, "help") == 0) {
usage();
} else if (strcmp(*argv, "dev") == 0) {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid'
2016-02-03 0:53 [PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid' Roopa Prabhu
@ 2016-02-03 8:20 ` Nicolas Dichtel
2016-02-05 0:48 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Dichtel @ 2016-02-03 8:20 UTC (permalink / raw)
To: Roopa Prabhu, stephen; +Cc: netdev
Le 03/02/2016 01:53, Roopa Prabhu a écrit :
> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>
> 'ip monitor all' is broken on older kernels.
> This patch fixes 'ip monitor all' to match
> 'all' and not 'all-nsid'.
>
> It moves parsing arg 'all-nsid' to after parsing
> 'all'.
>
> Before:
> $ip monitor all
> NETLINK_LISTEN_ALL_NSID: Protocol not available
>
> After:
> $ip monitor all
> [NEIGH]Deleted 10.0.0.1 dev eth1 lladdr c4:54:44:4f:b2:dd STALE
>
> Fixes: 449b824ad196 ("ipmonitor: allows to monitor in several netns")
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks•com>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind•com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid'
2016-02-03 0:53 [PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid' Roopa Prabhu
2016-02-03 8:20 ` Nicolas Dichtel
@ 2016-02-05 0:48 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2016-02-05 0:48 UTC (permalink / raw)
To: Roopa Prabhu; +Cc: netdev, nicolas.dichtel
On Tue, 2 Feb 2016 16:53:40 -0800
Roopa Prabhu <roopa@cumulusnetworks•com> wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>
> 'ip monitor all' is broken on older kernels.
> This patch fixes 'ip monitor all' to match
> 'all' and not 'all-nsid'.
>
> It moves parsing arg 'all-nsid' to after parsing
> 'all'.
>
> Before:
> $ip monitor all
> NETLINK_LISTEN_ALL_NSID: Protocol not available
>
> After:
> $ip monitor all
> [NEIGH]Deleted 10.0.0.1 dev eth1 lladdr c4:54:44:4f:b2:dd STALE
>
> Fixes: 449b824ad196 ("ipmonitor: allows to monitor in several netns")
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks•com>
Applied thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-05 0:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-03 0:53 [PATCH iproute2] ipmonitor: match user option 'all' before 'all-nsid' Roopa Prabhu
2016-02-03 8:20 ` Nicolas Dichtel
2016-02-05 0:48 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox