From: John Fastabend <john.fastabend@gmail•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: amir@vadai•me, jhs@mojatatu•com, davem@davemloft•net,
netdev@vger•kernel.org, jeffrey.t.kirsher@intel•com
Subject: Re: [net-next PATCH v2 3/8] net: sched: add cls_u32 offload hooks for netdevs
Date: Tue, 16 Feb 2016 19:21:29 -0800 [thread overview]
Message-ID: <56C3E739.9040903@gmail.com> (raw)
In-Reply-To: <20160216202049.GC2246@nanopsycho.orion>
On 16-02-16 12:20 PM, Jiri Pirko wrote:
> Tue, Feb 16, 2016 at 07:01:25AM CET, john.fastabend@gmail•com wrote:
>> This patch allows netdev drivers to consume cls_u32 offloads via
>> the ndo_setup_tc ndo op.
>>
>> This works aligns with how network drivers have been doing qdisc
>> offloads for mqprio.
>>
>> Signed-off-by: John Fastabend <john.r.fastabend@intel•com>
>
> <snip>
>
>> +struct tc_cls_u32_hnode {
>> + u32 handle;
>> + u32 prio;
>> + unsigned int divisor;
>> +};
>> +
>> +enum {
>
> Please name enum and ...
>
>> + TC_CLSU32_NEW_KNODE,
>> + TC_CLSU32_REPLACE_KNODE,
>> + TC_CLSU32_DELETE_KNODE,
>> + TC_CLSU32_NEW_HNODE,
>> + TC_CLSU32_REPLACE_HNODE,
>> + TC_CLSU32_DELETE_HNODE,
>> +};
>> +
>> +struct tc_cls_u32_offload {
>> + /* knode values */
>> + int command;
>
> ... use it here instead of "int"
>
Yep thanks. I'll go ahead and do this now.
next prev parent reply other threads:[~2016-02-17 3:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 6:00 [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe John Fastabend
2016-02-16 6:00 ` [net-next PATCH v2 1/8] net: rework ndo tc op to consume additional qdisc handle parameter John Fastabend
2016-02-16 20:15 ` Jiri Pirko
2016-02-16 6:00 ` [net-next PATCH v2 2/8] net: rework setup_tc ndo op to consume general tc operand John Fastabend
2016-02-16 20:17 ` Jiri Pirko
2016-02-28 14:11 ` Alaa Hleihel
2016-02-16 6:01 ` [net-next PATCH v2 3/8] net: sched: add cls_u32 offload hooks for netdevs John Fastabend
2016-02-16 20:20 ` Jiri Pirko
2016-02-17 3:21 ` John Fastabend [this message]
2016-02-16 6:01 ` [net-next PATCH v2 4/8] net: add tc offload feature flag John Fastabend
2016-02-16 20:22 ` Jiri Pirko
2016-02-16 6:02 ` [net-next PATCH v2 5/8] net: tc: helper functions to query action types John Fastabend
2016-02-16 20:26 ` Jiri Pirko
2016-02-17 3:21 ` John Fastabend
2016-02-16 6:02 ` [net-next PATCH v2 6/8] net: ixgbe: add minimal parser details for ixgbe John Fastabend
2016-02-16 6:03 ` [net-next PATCH v2 7/8] net: ixgbe: add support for tc_u32 offload John Fastabend
2016-02-16 6:03 ` [net-next PATCH v2 8/8] net: ixgbe: abort with cls u32 divisor groups greater than 1 John Fastabend
2016-02-16 19:30 ` [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe Or Gerlitz
2016-02-16 19:50 ` David Miller
2016-02-16 20:46 ` Or Gerlitz
2016-02-17 1:17 ` David Miller
2016-02-17 5:23 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C3E739.9040903@gmail.com \
--to=john.fastabend@gmail$(echo .)com \
--cc=amir@vadai$(echo .)me \
--cc=davem@davemloft$(echo .)net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox