From: Alaa Hleihel <alaa@dev•mellanox.co.il>
To: John Fastabend <john.fastabend@gmail•com>,
amir@vadai•me, jhs@mojatatu•com, davem@davemloft•net
Cc: netdev@vger•kernel.org, jiri@resnulli•us, jeffrey.t.kirsher@intel•com
Subject: Re: [net-next PATCH v2 2/8] net: rework setup_tc ndo op to consume general tc operand
Date: Sun, 28 Feb 2016 16:11:36 +0200 [thread overview]
Message-ID: <56D30018.5090208@dev.mellanox.co.il> (raw)
In-Reply-To: <20160216060057.32452.75845.stgit@john-Precision-Tower-5810>
Hi John,
On 2/16/2016 08:00, John Fastabend wrote:
> @@ -140,9 +141,11 @@ static int mqprio_init(struct Qdisc *sch, struct nlattr *opt)
> * supplied and verified mapping
> */
> if (qopt->hw) {
> + struct tc_to_netdev tc = {.type = TC_SETUP_MQPRIO,
> + .tc = qopt->num_tc};
> +
>
Using gcc 4.4.7, the compilation failed on these lines (since that compiler does not support anonymous unions):
CC [M] net/sched/sch_mqprio.o
net/sched/sch_mqprio.c: In function ?mqprio_init?:
net/sched/sch_mqprio.c:145: error: unknown field ?tc? specified in initializer
net/sched/sch_mqprio.c:145: warning: missing braces around initializer
net/sched/sch_mqprio.c:145: warning: (near initialization for ?tc.<anonymous>?)
make[2]: *** [net/sched/sch_mqprio.o] Error 1
make[1]: *** [net/sched] Error 2
make: *** [net] Error 2
It can be fixed by surrounding it with braces; something like:
diff --git a/net/sched/sch_mqprio.c b/net/sched/sch_mqprio.c
index f9947d1..9b844f7 100644
--- a/net/sched/sch_mqprio.c
+++ b/net/sched/sch_mqprio.c
@@ -142,7 +142,7 @@ static int mqprio_init(struct Qdisc *sch, struct nlattr *opt)
*/
if (qopt->hw) {
struct tc_to_netdev tc = {.type = TC_SETUP_MQPRIO,
- .tc = qopt->num_tc};
+ {.tc = qopt->num_tc}};
priv->hw_owned = 1;
err = dev->netdev_ops->ndo_setup_tc(dev, sch->handle, 0, &tc);
Would you please fix it ?
Regards,
Alaa
next prev parent reply other threads:[~2016-02-28 14:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 6:00 [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe John Fastabend
2016-02-16 6:00 ` [net-next PATCH v2 1/8] net: rework ndo tc op to consume additional qdisc handle parameter John Fastabend
2016-02-16 20:15 ` Jiri Pirko
2016-02-16 6:00 ` [net-next PATCH v2 2/8] net: rework setup_tc ndo op to consume general tc operand John Fastabend
2016-02-16 20:17 ` Jiri Pirko
2016-02-28 14:11 ` Alaa Hleihel [this message]
2016-02-16 6:01 ` [net-next PATCH v2 3/8] net: sched: add cls_u32 offload hooks for netdevs John Fastabend
2016-02-16 20:20 ` Jiri Pirko
2016-02-17 3:21 ` John Fastabend
2016-02-16 6:01 ` [net-next PATCH v2 4/8] net: add tc offload feature flag John Fastabend
2016-02-16 20:22 ` Jiri Pirko
2016-02-16 6:02 ` [net-next PATCH v2 5/8] net: tc: helper functions to query action types John Fastabend
2016-02-16 20:26 ` Jiri Pirko
2016-02-17 3:21 ` John Fastabend
2016-02-16 6:02 ` [net-next PATCH v2 6/8] net: ixgbe: add minimal parser details for ixgbe John Fastabend
2016-02-16 6:03 ` [net-next PATCH v2 7/8] net: ixgbe: add support for tc_u32 offload John Fastabend
2016-02-16 6:03 ` [net-next PATCH v2 8/8] net: ixgbe: abort with cls u32 divisor groups greater than 1 John Fastabend
2016-02-16 19:30 ` [net-next PATCH v2 0/8] tc offload for cls_u32 on ixgbe Or Gerlitz
2016-02-16 19:50 ` David Miller
2016-02-16 20:46 ` Or Gerlitz
2016-02-17 1:17 ` David Miller
2016-02-17 5:23 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D30018.5090208@dev.mellanox.co.il \
--to=alaa@dev$(echo .)mellanox.co.il \
--cc=amir@vadai$(echo .)me \
--cc=davem@davemloft$(echo .)net \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox