public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Tom Lendacky <thomas.lendacky@amd•com>
To: David Miller <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next v1 1/9] amd-xgbe: Disable VLAN filtering when in promiscuous mode
Date: Wed, 17 Feb 2016 10:09:34 -0600	[thread overview]
Message-ID: <56C49B3E.9030202@amd.com> (raw)
In-Reply-To: <20160216.201934.2034325737936595643.davem@davemloft.net>

On 02/16/2016 07:19 PM, David Miller wrote:
> From: Tom Lendacky <thomas.lendacky@amd•com>
> Date: Fri, 12 Feb 2016 08:32:24 -0600
> 
>> +#ifndef CRCPOLY_LE
>> +#define CRCPOLY_LE 0xedb88320
>> +#endif
>> +static u32 xgbe_vid_crc32_le(__le16 vid_le)
> 
> Please do not implement yet another copy of a CRC implementation.
> 
> Make use of the various versions the kernel provides already instead,
> add Kconfig dependencies as needed.

I can't use the existing kernel implementations because there aren't
any that support the 12-bit length of the VLAN VID (lengths are all
at the byte level). I created this function (back when I added VLAN
filtering support in 2014 - it's only being moved in this patch)
because of this 12-bit length.

I do use the kernel functions in other areas, I just can't use them
here.

Thanks,
Tom

> 
> Thanks.
> 

next prev parent reply	other threads:[~2016-02-17 16:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12 14:32 [PATCH net-next v1 0/9] amd-xgbe: AMD XGBE driver updates 2016-02-12 Tom Lendacky
2016-02-12 14:32 ` [PATCH net-next v1 1/9] amd-xgbe: Disable VLAN filtering when in promiscuous mode Tom Lendacky
2016-02-17  1:19   ` David Miller
2016-02-17 16:09     ` Tom Lendacky [this message]
2016-02-17 16:31       ` David Miller
2016-02-17 16:35         ` Tom Lendacky
2016-02-12 14:32 ` [PATCH net-next v1 2/9] amd-xgbe: Change from napi_complete to napi_complete_done Tom Lendacky
2016-02-12 14:32 ` [PATCH net-next v1 3/9] amd-xgbe: Use __napi_schedule_irqoff Tom Lendacky
2016-02-12 14:32 ` [PATCH net-next v1 4/9] amd-xgbe: Verify forced speed matches the active speedset Tom Lendacky
2016-02-12 14:33 ` [PATCH net-next v1 5/9] amd-xgbe: Enable/disable PFC per traffic class Tom Lendacky
2016-02-12 14:33 ` [PATCH net-next v1 6/9] amd-xgbe: Fix the mapping of priorities to traffic classes Tom Lendacky
2016-02-12 14:33 ` [PATCH net-next v1 7/9] amd-xgbe: Do traffic class setup when called through dcbnl Tom Lendacky
2016-02-12 14:33 ` [PATCH net-next v1 8/9] amd-xgbe: Check Rx queue fifos before stopping Rx DMA Tom Lendacky
2016-02-12 14:33 ` [PATCH net-next v1 9/9] amd-xgbe: Mask auto-negotiation interrupts in ISR Tom Lendacky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56C49B3E.9030202@amd.com \
    --to=thomas.lendacky@amd$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox