* [net-next 0/2] remove duplicate set of flag IFF_MULTICAST
@ 2016-03-16 9:59 Zhang Shengju
2016-03-16 9:59 ` [net-next 1/2] bonding: " Zhang Shengju
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Zhang Shengju @ 2016-03-16 9:59 UTC (permalink / raw)
To: davem, j.vosburgh, jiri; +Cc: netdev
This patch series remove duplicate set of flag IFF_MULTICAST.
Zhang Shengju (2):
bonding: remove duplicate set of flag IFF_MULTICAST
team: remove duplicate set of flag IFF_MULTICAST
drivers/net/bonding/bond_main.c | 2 +-
drivers/net/team/team.c | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [net-next 1/2] bonding: remove duplicate set of flag IFF_MULTICAST
2016-03-16 9:59 [net-next 0/2] remove duplicate set of flag IFF_MULTICAST Zhang Shengju
@ 2016-03-16 9:59 ` Zhang Shengju
2016-03-16 10:06 ` Nikolay Aleksandrov
2016-03-16 14:01 ` Andy Gospodarek
2016-03-16 9:59 ` [net-next 2/2] team: " Zhang Shengju
2016-03-19 2:15 ` [net-next 0/2] " David Miller
2 siblings, 2 replies; 8+ messages in thread
From: Zhang Shengju @ 2016-03-16 9:59 UTC (permalink / raw)
To: davem, j.vosburgh, jiri; +Cc: netdev
Remove unnecessary set of flag IFF_MULTICAST, since ether_setup
already does this.
Signed-off-by: Zhang Shengju <zhangshengju@cmss•chinamobile.com>
---
drivers/net/bonding/bond_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index b6236ff..270b39c 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4175,7 +4175,7 @@ void bond_setup(struct net_device *bond_dev)
SET_NETDEV_DEVTYPE(bond_dev, &bond_type);
/* Initialize the device options */
- bond_dev->flags |= IFF_MASTER|IFF_MULTICAST;
+ bond_dev->flags |= IFF_MASTER;
bond_dev->priv_flags |= IFF_BONDING | IFF_UNICAST_FLT | IFF_NO_QUEUE;
bond_dev->priv_flags &= ~(IFF_XMIT_DST_RELEASE | IFF_TX_SKB_SHARING);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [net-next 1/2] bonding: remove duplicate set of flag IFF_MULTICAST
2016-03-16 9:59 ` [net-next 1/2] bonding: " Zhang Shengju
@ 2016-03-16 10:06 ` Nikolay Aleksandrov
2016-03-16 14:01 ` Andy Gospodarek
1 sibling, 0 replies; 8+ messages in thread
From: Nikolay Aleksandrov @ 2016-03-16 10:06 UTC (permalink / raw)
To: Zhang Shengju, davem, j.vosburgh, jiri; +Cc: netdev, gospo, Veaceslav Falico
On 03/16/2016 10:59 AM, Zhang Shengju wrote:
> Remove unnecessary set of flag IFF_MULTICAST, since ether_setup
> already does this.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss•chinamobile.com>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
There're a few more bonding maintainers, I've added them to the CC list.
Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [net-next 1/2] bonding: remove duplicate set of flag IFF_MULTICAST
2016-03-16 9:59 ` [net-next 1/2] bonding: " Zhang Shengju
2016-03-16 10:06 ` Nikolay Aleksandrov
@ 2016-03-16 14:01 ` Andy Gospodarek
1 sibling, 0 replies; 8+ messages in thread
From: Andy Gospodarek @ 2016-03-16 14:01 UTC (permalink / raw)
To: Zhang Shengju; +Cc: davem, j.vosburgh, jiri, netdev
On Wed, Mar 16, 2016 at 09:59:15AM +0000, Zhang Shengju wrote:
> Remove unnecessary set of flag IFF_MULTICAST, since ether_setup
> already does this.
>
> Signed-off-by: Zhang Shengju <zhangshengju@cmss•chinamobile.com>
Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks•com>
> ---
> drivers/net/bonding/bond_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index b6236ff..270b39c 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -4175,7 +4175,7 @@ void bond_setup(struct net_device *bond_dev)
> SET_NETDEV_DEVTYPE(bond_dev, &bond_type);
>
> /* Initialize the device options */
> - bond_dev->flags |= IFF_MASTER|IFF_MULTICAST;
> + bond_dev->flags |= IFF_MASTER;
> bond_dev->priv_flags |= IFF_BONDING | IFF_UNICAST_FLT | IFF_NO_QUEUE;
> bond_dev->priv_flags &= ~(IFF_XMIT_DST_RELEASE | IFF_TX_SKB_SHARING);
>
> --
> 1.8.3.1
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [net-next 2/2] team: remove duplicate set of flag IFF_MULTICAST
2016-03-16 9:59 [net-next 0/2] remove duplicate set of flag IFF_MULTICAST Zhang Shengju
2016-03-16 9:59 ` [net-next 1/2] bonding: " Zhang Shengju
@ 2016-03-16 9:59 ` Zhang Shengju
2016-03-16 10:00 ` Jiri Pirko
2016-03-19 2:15 ` [net-next 0/2] " David Miller
2 siblings, 1 reply; 8+ messages in thread
From: Zhang Shengju @ 2016-03-16 9:59 UTC (permalink / raw)
To: davem, j.vosburgh, jiri; +Cc: netdev
Remove unnecessary set of flag IFF_MULTICAST, since ether_setup
already does this.
Signed-off-by: Zhang Shengju <zhangshengju@cmss•chinamobile.com>
---
drivers/net/team/team.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index 2769835..26c64d2 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -2082,7 +2082,6 @@ static void team_setup(struct net_device *dev)
dev->netdev_ops = &team_netdev_ops;
dev->ethtool_ops = &team_ethtool_ops;
dev->destructor = team_destructor;
- dev->flags |= IFF_MULTICAST;
dev->priv_flags &= ~(IFF_XMIT_DST_RELEASE | IFF_TX_SKB_SHARING);
dev->priv_flags |= IFF_NO_QUEUE;
dev->priv_flags |= IFF_TEAM;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [net-next 2/2] team: remove duplicate set of flag IFF_MULTICAST
2016-03-16 9:59 ` [net-next 2/2] team: " Zhang Shengju
@ 2016-03-16 10:00 ` Jiri Pirko
0 siblings, 0 replies; 8+ messages in thread
From: Jiri Pirko @ 2016-03-16 10:00 UTC (permalink / raw)
To: Zhang Shengju; +Cc: davem, j.vosburgh, netdev
Wed, Mar 16, 2016 at 10:59:16AM CET, zhangshengju@cmss•chinamobile.com wrote:
>Remove unnecessary set of flag IFF_MULTICAST, since ether_setup
>already does this.
>
>Signed-off-by: Zhang Shengju <zhangshengju@cmss•chinamobile.com>
Acked-by: Jiri Pirko <jiri@mellanox•com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [net-next 0/2] remove duplicate set of flag IFF_MULTICAST
2016-03-16 9:59 [net-next 0/2] remove duplicate set of flag IFF_MULTICAST Zhang Shengju
2016-03-16 9:59 ` [net-next 1/2] bonding: " Zhang Shengju
2016-03-16 9:59 ` [net-next 2/2] team: " Zhang Shengju
@ 2016-03-19 2:15 ` David Miller
2 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2016-03-19 2:15 UTC (permalink / raw)
To: zhangshengju; +Cc: j.vosburgh, jiri, netdev
From: Zhang Shengju <zhangshengju@cmss•chinamobile.com>
Date: Wed, 16 Mar 2016 09:59:14 +0000
> This patch series remove duplicate set of flag IFF_MULTICAST.
Series applied, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [net-next 1/2] bonding: remove duplicate set of flag IFF_MULTICAST
@ 2016-03-16 12:30 张胜举
0 siblings, 0 replies; 8+ messages in thread
From: 张胜举 @ 2016-03-16 12:30 UTC (permalink / raw)
To: 'Nikolay Aleksandrov'
Cc: netdev, gospo, 'Veaceslav Falico', davem, j.vosburgh,
jiri
> On 03/16/2016 10:59 AM, Zhang Shengju wrote:
> > Remove unnecessary set of flag IFF_MULTICAST, since ether_setup
> > already does this.
> >
> > Signed-off-by: Zhang Shengju <zhangshengju@cmss•chinamobile.com>
> > ---
> > drivers/net/bonding/bond_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> There're a few more bonding maintainers, I've added them to the CC list.
>
> Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
Thanks, Nikolay.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-03-19 2:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-16 9:59 [net-next 0/2] remove duplicate set of flag IFF_MULTICAST Zhang Shengju
2016-03-16 9:59 ` [net-next 1/2] bonding: " Zhang Shengju
2016-03-16 10:06 ` Nikolay Aleksandrov
2016-03-16 14:01 ` Andy Gospodarek
2016-03-16 9:59 ` [net-next 2/2] team: " Zhang Shengju
2016-03-16 10:00 ` Jiri Pirko
2016-03-19 2:15 ` [net-next 0/2] " David Miller
-- strict thread matches above, loose matches on Subject: below --
2016-03-16 12:30 [net-next 1/2] bonding: " 张胜举
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox