From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: f.fainelli@gmail•com, netdev@vger•kernel.org
Cc: arnd@arndb•de, Rob Herring <robh+dt@kernel•org>,
Frank Rowand <frowand.list@gmail•com>,
Grant Likely <grant.likely@linaro•org>
Subject: Re: [PATCH 5/5] of_mdio: get_phy_device() doesn't return NULL anymore
Date: Sun, 24 Apr 2016 20:37:31 +0300 [thread overview]
Message-ID: <571D045B.3020702@cogentembedded.com> (raw)
In-Reply-To: <2718908.IUaySUkXrd@wasted.cogentembedded.com>
On 04/24/2016 08:31 PM, Sergei Shtylyov wrote:
> Now that get_phy_device() no longer returns NULL on error, we don't need
> to check for it...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
>
Oops, forgot to CC: the DT people, doing that now...
> ---
> drivers/of/of_mdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: net-next/drivers/of/of_mdio.c
> ===================================================================
> --- net-next.orig/drivers/of/of_mdio.c
> +++ net-next/drivers/of/of_mdio.c
> @@ -56,7 +56,7 @@ static void of_mdiobus_register_phy(stru
> phy = phy_device_create(mdio, addr, phy_id, 0, NULL);
> else
> phy = get_phy_device(mdio, addr, is_c45);
> - if (IS_ERR_OR_NULL(phy))
> + if (IS_ERR(phy))
> return;
>
> rc = irq_of_parse_and_map(child, 0);
next prev parent reply other threads:[~2016-04-24 17:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 17:23 [PATCH 0/5] Don't return NULL from get_phy_device() anymore Sergei Shtylyov
2016-04-24 17:25 ` [PATCH 1/5] phylib: don't return NULL from get_phy_device() Sergei Shtylyov
2016-04-25 19:45 ` Florian Fainelli
[not found] ` <874mamzw5q.fsf@ketchup.mtl.sfl>
2016-04-27 19:49 ` Andrew Lunn
2016-04-27 20:09 ` Sergei Shtylyov
2016-04-27 20:23 ` David Miller
2016-04-27 22:03 ` Arnd Bergmann
2016-04-27 21:47 ` Florian Fainelli
2016-04-27 22:07 ` Arnd Bergmann
2016-04-27 20:12 ` Sergei Shtylyov
2016-04-27 20:11 ` Florian Fainelli
2016-04-24 17:27 ` [PATCH 2/5] xgene: get_phy_device() doesn't return NULL anymore Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:29 ` [PATCH 3/5] fixed_phy: " Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:30 ` [PATCH 4/5] mdio_bus: " Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:31 ` [PATCH 5/5] of_mdio: " Sergei Shtylyov
2016-04-24 17:37 ` Sergei Shtylyov [this message]
2016-04-25 19:47 ` Florian Fainelli
2016-04-26 19:41 ` [PATCH 0/5] Don't return NULL from get_phy_device() anymore David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571D045B.3020702@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=f.fainelli@gmail$(echo .)com \
--cc=frowand.list@gmail$(echo .)com \
--cc=grant.likely@linaro$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox