From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux•com>,
"David S. Miller" <davem@davemloft•net>,
f.fainelli@gmail•com
Cc: arnd@arndb•de, Andrew Lunn <andrew@lunn•ch>,
netdev@vger•kernel.org, kernel@savoirfairelinux•com
Subject: Re: [PATCH 1/5] phylib: don't return NULL from get_phy_device()
Date: Wed, 27 Apr 2016 23:12:25 +0300 [thread overview]
Message-ID: <57211D29.2050704@cogentembedded.com> (raw)
In-Reply-To: <874mamzw5q.fsf@ketchup.mtl.sfl>
Hello.
On 04/27/2016 10:30 PM, Vivien Didelot wrote:
>> Arnd Bergmann asked that get_phy_device() returns either NULL or the error
>> value, not both on error. Do as he said, return ERR_PTR(-ENODEV) instead
>> of NULL when the PHY ID registers read as all ones.
>>
>> Suggested-by: Arnd Bergmann <arnd@arndb•de>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
>>
>> ---
>> drivers/net/phy/phy_device.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: net-next/drivers/net/phy/phy_device.c
>> ===================================================================
>> --- net-next.orig/drivers/net/phy/phy_device.c
>> +++ net-next/drivers/net/phy/phy_device.c
>> @@ -529,7 +529,7 @@ struct phy_device *get_phy_device(struct
>>
>> /* If the phy_id is mostly Fs, there is no device there */
>> if ((phy_id & 0x1fffffff) == 0x1fffffff)
>> - return NULL;
>> + return ERR_PTR(-ENODEV);
>>
>> return phy_device_create(bus, addr, phy_id, is_c45, &c45_ids);
>> }
>
> This particular commit, merged as:
>
> b74766a0a0fe ("phylib: don't return NULL from get_phy_device()")
>
> breaks my 3-switch DSA setup with the following error:
>
> fec: probe of 400d1000.ethernet failed with error -22
>
> Reverting c971c0e580a6 ("Merge branch 'get_phy_device-retval'") restores
> a working setup.
I think I was able to follow this to the get_phy_device() call in
fixed_phy_register() but I'm unable to see why it fails now and didn't before.
Are you using fixed_phy.c at all?
> Thanks,
>
> Vivien
MBR, Sergei
next prev parent reply other threads:[~2016-04-27 20:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 17:23 [PATCH 0/5] Don't return NULL from get_phy_device() anymore Sergei Shtylyov
2016-04-24 17:25 ` [PATCH 1/5] phylib: don't return NULL from get_phy_device() Sergei Shtylyov
2016-04-25 19:45 ` Florian Fainelli
[not found] ` <874mamzw5q.fsf@ketchup.mtl.sfl>
2016-04-27 19:49 ` Andrew Lunn
2016-04-27 20:09 ` Sergei Shtylyov
2016-04-27 20:23 ` David Miller
2016-04-27 22:03 ` Arnd Bergmann
2016-04-27 21:47 ` Florian Fainelli
2016-04-27 22:07 ` Arnd Bergmann
2016-04-27 20:12 ` Sergei Shtylyov [this message]
2016-04-27 20:11 ` Florian Fainelli
2016-04-24 17:27 ` [PATCH 2/5] xgene: get_phy_device() doesn't return NULL anymore Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:29 ` [PATCH 3/5] fixed_phy: " Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:30 ` [PATCH 4/5] mdio_bus: " Sergei Shtylyov
2016-04-25 19:46 ` Florian Fainelli
2016-04-24 17:31 ` [PATCH 5/5] of_mdio: " Sergei Shtylyov
2016-04-24 17:37 ` Sergei Shtylyov
2016-04-25 19:47 ` Florian Fainelli
2016-04-26 19:41 ` [PATCH 0/5] Don't return NULL from get_phy_device() anymore David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57211D29.2050704@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kernel@savoirfairelinux$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox