From: Ben Greear <greearb@candelatech•com>
To: Ben Hutchings <ben@decadent•org.uk>,
Sabrina Dubroca <sd@queasysnail•net>
Cc: Hannes Frederic Sowa <hannes@stressinduktion•org>,
linux-kernel@vger•kernel.org, stable@vger•kernel.org,
akpm@linux-foundation•org,
"David S. Miller" <davem@davemloft•net>,
Vijay Pandurangan <vijayp@vijayp•ca>,
Cong Wang <cwang@twopensource•com>,
netdev@vger•kernel.org, Evan Jones <ej@evanjones•ca>,
Nicolas Dichtel <nicolas.dichtel@6wind•com>,
Phil Sutter <phil@nwl•cc>,
Toshiaki Makita <makita.toshiaki@lab•ntt.co.jp>,
xiyou.wangcong@gmail•com
Subject: Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.
Date: Sat, 30 Apr 2016 12:40:07 -0700 [thread overview]
Message-ID: <57250A17.5090804@candelatech.com> (raw)
In-Reply-To: <1462041181.17662.3.camel@decadent.org.uk>
On 04/30/2016 11:33 AM, Ben Hutchings wrote:
> On Thu, 2016-04-28 at 12:29 +0200, Sabrina Dubroca wrote:
>> Hello,
>>> http://dmz2.candelatech.com/?p=linux-4.4.dev.y/.git;a=commitdiff;h=8153e983c0e5eba1aafe1fc296248ed2a553f1ac;hp=454b07405d694dad52e7f41af5816eed0190da8a
>> Actually, no, this is not really a regression.
> [...]
>
> It really is. Even though the old behaviour was a bug (raw packets
> should not be changed), if there are real applications that depend on
> that then we have to keep those applications working somehow.
To be honest, I fail to see why the old behaviour is a bug when sending
raw packets from user-space. If raw packets should not be changed, then
we need some way to specify what the checksum setting is to begin with,
otherwise, user-space has not enough control.
A socket option for new programs, and sysctl configurable defaults for raw sockets
for old binary programs would be sufficient I think.
Thanks,
Ben
--
Ben Greear <greearb@candelatech•com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2016-04-30 19:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <lsq.1461711744.351546278@decadent.org.uk>
2016-04-26 23:02 ` [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good Ben Hutchings
2016-04-27 15:59 ` Ben Greear
2016-04-27 18:07 ` Ben Hutchings
2016-04-28 0:00 ` Hannes Frederic Sowa
2016-04-28 0:14 ` Ben Greear
2016-04-28 10:29 ` Sabrina Dubroca
2016-04-28 13:45 ` Ben Greear
2016-04-30 19:18 ` Ben Hutchings
2016-04-30 18:33 ` Ben Hutchings
2016-04-30 19:40 ` Ben Greear [this message]
2016-04-30 19:54 ` Tom Herbert
2016-04-30 20:59 ` Ben Greear
2016-04-30 21:13 ` Vijay Pandurangan
2016-04-30 21:29 ` Ben Greear
2016-04-30 21:36 ` Vijay Pandurangan
2016-04-30 21:52 ` Ben Greear
2016-04-30 22:01 ` Vijay Pandurangan
2016-04-30 22:43 ` Ben Greear
2016-05-01 5:30 ` [PATCH 3.2 085/115] veth: don???t " Willy Tarreau
2016-05-13 16:57 ` Ben Greear
2016-05-13 18:21 ` David Miller
2016-05-13 18:23 ` Ben Greear
2016-04-30 22:42 ` [PATCH 3.2 085/115] veth: don’t " Tom Herbert
2016-04-30 20:15 ` Vijay Pandurangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57250A17.5090804@candelatech.com \
--to=greearb@candelatech$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ben@decadent$(echo .)org.uk \
--cc=cwang@twopensource$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ej@evanjones$(echo .)ca \
--cc=hannes@stressinduktion$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=makita.toshiaki@lab$(echo .)ntt.co.jp \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=phil@nwl$(echo .)cc \
--cc=sd@queasysnail$(echo .)net \
--cc=stable@vger$(echo .)kernel.org \
--cc=vijayp@vijayp$(echo .)ca \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox