From: David Ahern <dsa@cumulusnetworks•com>
To: Shmulik Ladkani <shmulik.ladkani@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: l3mdev: Add hook in ip and ipv6
Date: Sat, 7 May 2016 08:50:49 -0600 [thread overview]
Message-ID: <572E00C9.4050109@cumulusnetworks.com> (raw)
In-Reply-To: <20160507113025.67c3ab43@halley>
On 5/7/16 2:30 AM, Shmulik Ladkani wrote:
> Hi David,
>
> On Fri, 6 May 2016 18:49:40 -0700 David Ahern <dsa@cumulusnetworks•com> wrote:
>> +static bool ipv6_ndisc_frame(const struct sk_buff *skb)
>> +{
>> + const struct ipv6hdr *ipv6h = (struct ipv6hdr *)skb->data;
>> + size_t hlen = sizeof(*ipv6h);
>> + bool rc = false;
>> +
>> + if (ipv6h->nexthdr == NEXTHDR_ICMP) {
>> + const struct icmp6hdr *icmph;
>> +
>> + if (skb->len < hlen + sizeof(*icmph))
>> + goto out;
>> +
>> + icmph = (struct icmp6hdr *)(skb->data + sizeof(*ipv6h));
>> + switch (icmph->icmp6_type) {
>
> Don't we need an additional pskb_may_pull here?
>
> If I get it right, 'ipv6_rcv' only assures sizeof(ipv6hdr) to be in the
> linear header (unless it's a NEXTHDR_HOP, which is not the case here).
yes, I inadvertently dropped this:
commit 65c38aa653c14df49e19faad74bd375f36e61c57
Author: David Ahern <dsa@cumulusnetworks•com>
Date: Tue Feb 23 10:10:26 2016 -0800
net: vrf: Remove direct access to skb->data
when I forward ported this patch. Will fix and re-send.
>
>> +static inline
>> +struct sk_buff *l3mdev_l3_rcv(struct sk_buff *skb, u16 proto)
>> +{
>> + struct net_device *master = NULL;
>> +
>> + if (netif_is_l3_slave(skb->dev))
>> + master = netdev_master_upper_dev_get_rcu(skb->dev);
>> +
>> + else if (netif_is_l3_master(skb->dev))
>> + master = skb->dev;
>> +
>> + if (master && master->l3mdev_ops->l3mdev_l3_rcv)
>> + skb = master->l3mdev_ops->l3mdev_l3_rcv(master, skb, proto);
>
> In the case where netif_is_l3_master(skb->dev) is true, can you explain
> why we need to pass it through the l3mdev_l3_rcv callback again?
what do you mean again? This is only time the l3mdev_l3_rcv method is
called on a packet.
next prev parent reply other threads:[~2016-05-07 14:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 1:49 [PATCH net-next v2 0/2] net: vrf: Fixup PKTINFO to return enslaved device index David Ahern
2016-05-07 1:49 ` [PATCH net-next v2 1/2] net: l3mdev: Add hook in ip and ipv6 David Ahern
2016-05-07 8:30 ` Shmulik Ladkani
2016-05-07 14:50 ` David Ahern [this message]
2016-05-07 18:32 ` Shmulik Ladkani
2016-05-08 2:25 ` David Ahern
2016-05-08 5:44 ` Shmulik Ladkani
2016-05-07 1:49 ` [PATCH net-next 2/2] net: original ingress device index in PKTINFO David Ahern
2016-05-07 8:41 ` Shmulik Ladkani
2016-05-07 14:53 ` David Ahern
2016-05-07 19:08 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572E00C9.4050109@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shmulik.ladkani@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox