From: David Ahern <dsa@cumulusnetworks•com>
To: Shmulik Ladkani <shmulik.ladkani@gmail•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next 2/2] net: original ingress device index in PKTINFO
Date: Sat, 7 May 2016 08:53:44 -0600 [thread overview]
Message-ID: <572E0178.4010601@cumulusnetworks.com> (raw)
In-Reply-To: <20160507114148.347716e4@halley>
On 5/7/16 2:41 AM, Shmulik Ladkani wrote:
> Hi David,
>
> On Fri, 6 May 2016 18:49:41 -0700 David Ahern <dsa@cumulusnetworks•com> wrote:
>> Applications such as OSPF and BFD need the original ingress device not
>> the VRF device;
>
> Would you consider this true for any IP_PKTINFO users in VRF setups?
yes. I was just giving specific examples, but certainly every app I am
aware of wants the enslaved index. If an app pops up that wants the vrf
index it can be derived from the enslaved index.
>
>> @@ -1193,7 +1193,12 @@ void ipv4_pktinfo_prepare(const struct sock *sk, struct sk_buff *skb)
>> ipv6_sk_rxinfo(sk);
>>
>> if (prepare && skb_rtable(skb)) {
>> - pktinfo->ipi_ifindex = inet_iif(skb);
>> + /* skb->cb is overloaded: prior to this point it is IP{6}CB
>> + * which has interface index (iif) as the first member of the
>> + * underlying inet{6}_skb_parm struct. This code then overlays
>> + * PKTINFO_SKB_CB and in_pktinfo also has iif as the first
>> + * element so the iif is picked up from the prior IPCB
>> + */
>
> Better if there was a guarantee in the code that inet_skb_parm layout stays
> that way. Or instead just explicitly assign the iif.
At this point inet_iif points to the vrf device so can't use it.
next prev parent reply other threads:[~2016-05-07 14:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 1:49 [PATCH net-next v2 0/2] net: vrf: Fixup PKTINFO to return enslaved device index David Ahern
2016-05-07 1:49 ` [PATCH net-next v2 1/2] net: l3mdev: Add hook in ip and ipv6 David Ahern
2016-05-07 8:30 ` Shmulik Ladkani
2016-05-07 14:50 ` David Ahern
2016-05-07 18:32 ` Shmulik Ladkani
2016-05-08 2:25 ` David Ahern
2016-05-08 5:44 ` Shmulik Ladkani
2016-05-07 1:49 ` [PATCH net-next 2/2] net: original ingress device index in PKTINFO David Ahern
2016-05-07 8:41 ` Shmulik Ladkani
2016-05-07 14:53 ` David Ahern [this message]
2016-05-07 19:08 ` Shmulik Ladkani
-- strict thread matches above, loose matches on Subject: below --
2016-05-10 18:19 [PATCH net-next v4 0/2] net: vrf: Fixup PKTINFO to return enslaved device index David Ahern
2016-05-10 18:19 ` [PATCH net-next 2/2] net: original ingress device index in PKTINFO David Ahern
2016-05-08 4:16 [PATCH net-next v3 0/2] net: vrf: Fixup PKTINFO to return enslaved device index David Ahern
2016-05-08 4:16 ` [PATCH net-next 2/2] net: original ingress device index in PKTINFO David Ahern
2016-05-05 19:37 [PATCH net-next 0/2] net: vrf: Fixup PKTINFO to return enslaved device index David Ahern
2016-05-05 19:37 ` [PATCH net-next 2/2] net: original ingress device index in PKTINFO David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572E0178.4010601@cumulusnetworks.com \
--to=dsa@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shmulik.ladkani@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox