From: Daniel Borkmann <daniel@iogearbox•net>
To: Jakub Kicinski <jakub.kicinski@netronome•com>, netdev@vger•kernel.org
Cc: ast@kernel•org, dinan.gunawardena@netronome•com
Subject: Re: [RFC 03/12] net: cls_bpf: limit hardware offload by software-only flag
Date: Wed, 01 Jun 2016 21:40:23 +0200 [thread overview]
Message-ID: <574F3A27.5050208@iogearbox.net> (raw)
In-Reply-To: <1464799814-4453-4-git-send-email-jakub.kicinski@netronome.com>
On 06/01/2016 06:50 PM, Jakub Kicinski wrote:
> Add cls_bpf support for the TCA_CLS_FLAGS_SKIP_HW flag.
> Unlike U32 and flower cls_bpf already has some netlink
> flags defined. I chose to create a new attribute to be
> able to use the same flag values as the above.
Yeah, that's totally fine to make it a new flag attribute.
> Unknown flags are ignored and not reported upon dump.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome•com>
> Reviewed-by: Dinan Gunawardena <dgunawardena@netronome•com>
> Reviewed-by: Simon Horman <simon.horman@netronome•com>
[...]
> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
> index f4297c8a42fe..93a86edf3bd8 100644
> --- a/include/uapi/linux/pkt_cls.h
> +++ b/include/uapi/linux/pkt_cls.h
> @@ -395,6 +395,7 @@ enum {
> TCA_BPF_FD,
> TCA_BPF_NAME,
> TCA_BPF_FLAGS,
> + TCA_BPF_GEN_TCA_FLAGS,
Small nit for the non-RFC set: I'd simply name that TCA_BPF_FLAGS_GEN.
> __TCA_BPF_MAX,
> };
>
[...]
> @@ -400,8 +406,11 @@ static int cls_bpf_modify_existing(struct net *net, struct tcf_proto *tp,
>
> have_exts = bpf_flags & TCA_BPF_FLAG_ACT_DIRECT;
> }
> + if (tb[TCA_BPF_GEN_TCA_FLAGS])
> + gen_flags = nla_get_u32(tb[TCA_BPF_GEN_TCA_FLAGS]);
>
> prog->exts_integrated = have_exts;
> + prog->gen_flags = gen_flags & CLS_BPF_SUPPORTED_GEN_FLAGS;
Invalid flags should probably be rejected here with -EINVAL or something.
> ret = is_bpf ? cls_bpf_prog_from_ops(tb, prog) :
> cls_bpf_prog_from_efd(tb, prog, tp);
> @@ -568,6 +577,9 @@ static int cls_bpf_dump(struct net *net, struct tcf_proto *tp, unsigned long fh,
> bpf_flags |= TCA_BPF_FLAG_ACT_DIRECT;
> if (bpf_flags && nla_put_u32(skb, TCA_BPF_FLAGS, bpf_flags))
> goto nla_put_failure;
> + if (prog->gen_flags &&
> + nla_put_u32(skb, TCA_BPF_GEN_TCA_FLAGS, prog->gen_flags))
> + goto nla_put_failure;
>
> nla_nest_end(skb, nest);
>
>
Otherwise looks good:
Acked-by: Daniel Borkmann <daniel@iogearbox•net>
next prev parent reply other threads:[~2016-06-01 19:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 16:50 [RFC 00/12] BPF hardware offload via cls_bpf Jakub Kicinski
2016-06-01 16:50 ` [RFC 01/12] add basic register-field manipulation macros Jakub Kicinski
2016-06-01 20:15 ` Hannes Frederic Sowa
2016-06-01 23:08 ` Jakub Kicinski
2016-06-02 12:01 ` Hannes Frederic Sowa
2016-06-01 16:50 ` [RFC 02/12] net: cls_bpf: add hardware offload Jakub Kicinski
2016-06-01 17:13 ` John Fastabend
2016-06-01 20:59 ` Jakub Kicinski
2016-06-01 19:34 ` Daniel Borkmann
2016-06-02 7:17 ` Jiri Pirko
2016-06-02 12:07 ` Jakub Kicinski
2016-06-01 16:50 ` [RFC 03/12] net: cls_bpf: limit hardware offload by software-only flag Jakub Kicinski
2016-06-01 17:16 ` John Fastabend
2016-06-01 17:16 ` John Fastabend
2016-06-01 19:40 ` Daniel Borkmann [this message]
2016-06-01 21:05 ` Jakub Kicinski
2016-06-01 21:21 ` Daniel Borkmann
2016-06-01 21:26 ` Jakub Kicinski
2016-06-01 21:31 ` Daniel Borkmann
2016-06-02 7:24 ` Jiri Pirko
2016-06-01 16:50 ` [RFC 04/12] net: cls_bpf: add support for marking filters as hardware-only Jakub Kicinski
2016-06-01 17:19 ` John Fastabend
2016-06-01 19:57 ` Daniel Borkmann
2016-06-01 16:50 ` [RFC 05/12] nfp: add BPF to NFP code translator Jakub Kicinski
2016-06-01 20:03 ` Daniel Borkmann
2016-06-01 20:09 ` John Fastabend
2016-06-01 20:15 ` Alexei Starovoitov
2016-06-01 21:23 ` Jakub Kicinski
2016-06-02 16:21 ` John Fastabend
2016-06-01 16:50 ` [RFC 06/12] nfp: add hardware cls_bpf offload Jakub Kicinski
2016-06-01 20:20 ` Daniel Borkmann
2016-06-01 20:52 ` Alexei Starovoitov
2016-06-01 21:15 ` Jakub Kicinski
2016-06-01 21:51 ` Alexei Starovoitov
2016-06-01 21:16 ` Daniel Borkmann
2016-06-01 21:36 ` John Fastabend
2016-06-02 6:57 ` Jiri Pirko
2016-06-02 12:13 ` Jakub Kicinski
2016-06-02 12:30 ` Daniel Borkmann
2016-06-01 23:03 ` Daniel Borkmann
2016-06-01 16:50 ` [RFC 07/12] nfp: add skb mark support to the bpf offload Jakub Kicinski
2016-06-01 21:56 ` Alexei Starovoitov
2016-06-01 22:19 ` Jakub Kicinski
2016-06-01 22:30 ` Daniel Borkmann
2016-06-01 23:01 ` Jakub Kicinski
2016-06-01 16:50 ` [RFC 08/12] net: cls_bpf: allow offloaded filters to update stats Jakub Kicinski
2016-06-01 17:20 ` John Fastabend
2016-06-01 22:09 ` Daniel Borkmann
2016-06-01 16:50 ` [RFC 09/12] nfp: report statistics of offloaded filters Jakub Kicinski
2016-06-01 16:50 ` [RFC 10/12] nfp: bpf: optimize register init Jakub Kicinski
2016-06-01 16:50 ` [RFC 11/12] nfp: bpf: add register rename Jakub Kicinski
2016-06-01 16:50 ` [RFC 12/12] nfp: bpf: add denser mode of execution Jakub Kicinski
2016-06-01 22:01 ` Alexei Starovoitov
2016-06-01 22:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574F3A27.5050208@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=ast@kernel$(echo .)org \
--cc=dinan.gunawardena@netronome$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox