From: Daniel Borkmann <daniel@iogearbox•net>
To: Jakub Kicinski <jakub.kicinski@netronome•com>,
Alexei Starovoitov <alexei.starovoitov@gmail•com>
Cc: netdev@vger•kernel.org, ast@kernel•org, dinan.gunawardena@netronome•com
Subject: Re: [RFC 07/12] nfp: add skb mark support to the bpf offload
Date: Thu, 02 Jun 2016 00:30:07 +0200 [thread overview]
Message-ID: <574F61EF.4000300@iogearbox.net> (raw)
In-Reply-To: <20160601231936.63c53f69@jkicinski-Precision-T1700>
On 06/02/2016 12:19 AM, Jakub Kicinski wrote:
> On Wed, 1 Jun 2016 14:56:26 -0700, Alexei Starovoitov wrote:
>> On Wed, Jun 01, 2016 at 05:50:09PM +0100, Jakub Kicinski wrote:
>>> Skb marking should be set in designated register, FW will
>>> prepend it to the packet for us.
>>>
>>> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome•com>
>>> Reviewed-by: Dinan Gunawardena <dgunawardena@netronome•com>
>>> Reviewed-by: Simon Horman <simon.horman@netronome•com>
>>> ---
>>> drivers/net/ethernet/netronome/nfp/nfp_bpf_jit.c | 20 ++++++++++++++++++++
>>> drivers/net/ethernet/netronome/nfp/nfp_net.h | 2 +-
>>> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 8 +++++++-
>>> 3 files changed, 28 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_bpf_jit.c b/drivers/net/ethernet/netronome/nfp/nfp_bpf_jit.c
>>> index d7eecfceba5c..b31e673a6fe8 100644
>>> --- a/drivers/net/ethernet/netronome/nfp/nfp_bpf_jit.c
>>> +++ b/drivers/net/ethernet/netronome/nfp/nfp_bpf_jit.c
>>> @@ -46,6 +46,8 @@
>>>
>>> #define REG_IMM0_N 30 /* Bank AB */
>>> #define REG_QNUM 29 /* Bank AB */
>>> +#define REG_MARK 28 /* Bank A */
>>> +#define REG_MARK_STS 28 /* Bank B */
>>>
>>> /* --- NFP prog --- */
>>> /* Foreach "multiple" entries macros provide pos and next<n> pointers.
>>> @@ -416,6 +418,15 @@ static int construct_data_ld(struct nfp_prog *nfp_prog, u16 offset, u8 size)
>>> return construct_data_ind_ld(nfp_prog, offset, 0, false, size);
>>> }
>>>
>>> +static int wrp_skb_mark(struct nfp_prog *nfp_prog, u16 src)
>>> +{
>>> + __emit_alu(nfp_prog, REG_MARK, ALU_DST_A, REG_NONE, ALU_OP_NONE, src,
>>> + false, false);
>>> + __emit_immed(nfp_prog, REG_MARK_STS, ALU_DST_B, 1, false);
>>> +
>>> + return 0;
>>> +}
>>> +
>>> static int
>>> construct_br_imm(struct nfp_prog *nfp_prog, u32 imm, u16 dst, u8 br, u16 off,
>>> enum alu_op alu_op, bool sw)
>>> @@ -538,6 +549,14 @@ static int imm_ld8(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta)
>>> return 0;
>>> }
>>>
>>> +static int mem_stx4(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta)
>>> +{
>>> + if (meta->insn.off == offsetof(struct sk_buff, mark))
>>> + return wrp_skb_mark(nfp_prog, meta->insn.src_reg * 2);
>>
>> couldn't figure out from the diff or commit log...
>> what is the meaning of 'skb->mark' for nfp?
>> Looks like it's writing into magic register and fw will do something
>> with that register?
>> 'mark' is packet metadata. Could you explain how it's passing
>> this metadata? Is it on the wire as well or somehow in the wire
>> only between two nfps?
>> Looks like interesting feature.
>
> Oh, it's not a magic register, it just an "API" I have between the BPF
> and the datapath firmware. Whatever is put in that register will be
> prepended to the packet (if the mark status register is set).
That is very useful indeed!
Btw, do you later on plan to also add something similar like TC_ACT_REDIRECT,
f.e. to push the packet same or different NIC port out again w/o leaving the
HW?
next prev parent reply other threads:[~2016-06-01 22:30 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 16:50 [RFC 00/12] BPF hardware offload via cls_bpf Jakub Kicinski
2016-06-01 16:50 ` [RFC 01/12] add basic register-field manipulation macros Jakub Kicinski
2016-06-01 20:15 ` Hannes Frederic Sowa
2016-06-01 23:08 ` Jakub Kicinski
2016-06-02 12:01 ` Hannes Frederic Sowa
2016-06-01 16:50 ` [RFC 02/12] net: cls_bpf: add hardware offload Jakub Kicinski
2016-06-01 17:13 ` John Fastabend
2016-06-01 20:59 ` Jakub Kicinski
2016-06-01 19:34 ` Daniel Borkmann
2016-06-02 7:17 ` Jiri Pirko
2016-06-02 12:07 ` Jakub Kicinski
2016-06-01 16:50 ` [RFC 03/12] net: cls_bpf: limit hardware offload by software-only flag Jakub Kicinski
2016-06-01 17:16 ` John Fastabend
2016-06-01 17:16 ` John Fastabend
2016-06-01 19:40 ` Daniel Borkmann
2016-06-01 21:05 ` Jakub Kicinski
2016-06-01 21:21 ` Daniel Borkmann
2016-06-01 21:26 ` Jakub Kicinski
2016-06-01 21:31 ` Daniel Borkmann
2016-06-02 7:24 ` Jiri Pirko
2016-06-01 16:50 ` [RFC 04/12] net: cls_bpf: add support for marking filters as hardware-only Jakub Kicinski
2016-06-01 17:19 ` John Fastabend
2016-06-01 19:57 ` Daniel Borkmann
2016-06-01 16:50 ` [RFC 05/12] nfp: add BPF to NFP code translator Jakub Kicinski
2016-06-01 20:03 ` Daniel Borkmann
2016-06-01 20:09 ` John Fastabend
2016-06-01 20:15 ` Alexei Starovoitov
2016-06-01 21:23 ` Jakub Kicinski
2016-06-02 16:21 ` John Fastabend
2016-06-01 16:50 ` [RFC 06/12] nfp: add hardware cls_bpf offload Jakub Kicinski
2016-06-01 20:20 ` Daniel Borkmann
2016-06-01 20:52 ` Alexei Starovoitov
2016-06-01 21:15 ` Jakub Kicinski
2016-06-01 21:51 ` Alexei Starovoitov
2016-06-01 21:16 ` Daniel Borkmann
2016-06-01 21:36 ` John Fastabend
2016-06-02 6:57 ` Jiri Pirko
2016-06-02 12:13 ` Jakub Kicinski
2016-06-02 12:30 ` Daniel Borkmann
2016-06-01 23:03 ` Daniel Borkmann
2016-06-01 16:50 ` [RFC 07/12] nfp: add skb mark support to the bpf offload Jakub Kicinski
2016-06-01 21:56 ` Alexei Starovoitov
2016-06-01 22:19 ` Jakub Kicinski
2016-06-01 22:30 ` Daniel Borkmann [this message]
2016-06-01 23:01 ` Jakub Kicinski
2016-06-01 16:50 ` [RFC 08/12] net: cls_bpf: allow offloaded filters to update stats Jakub Kicinski
2016-06-01 17:20 ` John Fastabend
2016-06-01 22:09 ` Daniel Borkmann
2016-06-01 16:50 ` [RFC 09/12] nfp: report statistics of offloaded filters Jakub Kicinski
2016-06-01 16:50 ` [RFC 10/12] nfp: bpf: optimize register init Jakub Kicinski
2016-06-01 16:50 ` [RFC 11/12] nfp: bpf: add register rename Jakub Kicinski
2016-06-01 16:50 ` [RFC 12/12] nfp: bpf: add denser mode of execution Jakub Kicinski
2016-06-01 22:01 ` Alexei Starovoitov
2016-06-01 22:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574F61EF.4000300@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=dinan.gunawardena@netronome$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox