From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Eric Dumazet <eric.dumazet@gmail•com>, Florian Westphal <fw@strlen•de>
Cc: David Miller <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>,
Stas Nichiporovich <stasn77@gmail•com>,
WANG Cong <xiyou.wangcong@gmail•com>
Subject: Re: [PATCH v2 net] fq_codel: fix NET_XMIT_CN behavior
Date: Sun, 5 Jun 2016 09:03:10 -0400 [thread overview]
Message-ID: <5754230E.3040508@mojatatu.com> (raw)
In-Reply-To: <1465070113.2968.18.camel@edumazet-glaptop3.roam.corp.google.com>
On 16-06-04 03:55 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google•com>
>
> My prior attempt to fix the backlogs of parents failed.
>
> If we return NET_XMIT_CN, our parents wont increase their backlog,
> so our qdisc_tree_reduce_backlog() should take this into account.
>
> v2: Florian Westphal pointed out that we could drop the packet,
> so we need to save qdisc_pkt_len(skb) in a temp variable before
> calling fq_codel_drop()
>
> Fixes: 9d18562a2278 ("fq_codel: add batch ability to fq_codel_drop()")
> Fixes: 2ccccf5fb43f ("net_sched: update hierarchical backlog too")
> Reported-by: Stas Nichiporovich <stasn77@gmail•com>
> Signed-off-by: Eric Dumazet <edumazet@google•com>
> Cc: WANG Cong <xiyou.wangcong@gmail•com>
> Cc: Jamal Hadi Salim <jhs@mojatatu•com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu•com>
cheers,
jamal
next prev parent reply other threads:[~2016-06-05 13:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 17:43 [PATCH net] fq_codel: fix NET_XMIT_CN behavior Eric Dumazet
2016-06-04 19:03 ` [net] " Florian Westphal
2016-06-04 19:40 ` Eric Dumazet
2016-06-04 19:55 ` [PATCH v2 net] " Eric Dumazet
2016-06-05 13:03 ` Jamal Hadi Salim [this message]
2016-06-05 20:30 ` Cong Wang
2016-06-05 20:54 ` Eric Dumazet
2016-06-05 20:55 ` Eric Dumazet
2016-06-05 23:30 ` Cong Wang
2016-06-06 10:49 ` Jamal Hadi Salim
2016-06-06 11:42 ` Florian Westphal
2016-06-06 14:37 ` Eric Dumazet
2016-06-06 16:18 ` Florian Westphal
2016-06-10 12:02 ` Jamal Hadi Salim
2016-06-06 14:29 ` Eric Dumazet
2016-06-07 22:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5754230E.3040508@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stasn77@gmail$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox