From: Daniel Borkmann <daniel@iogearbox•net>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: David Miller <davem@davemloft•net>,
Alexei Starovoitov <alexei.starovoitov@gmail•com>,
john fastabend <john.fastabend@gmail•com>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Linux Kernel Network Developers <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next] net, cls: allow for deleting all filters for given parent
Date: Mon, 06 Jun 2016 22:32:48 +0200 [thread overview]
Message-ID: <5755DDF0.4060503@iogearbox.net> (raw)
In-Reply-To: <CAM_iQpXJAa5B=4ez9z+-Q66rFj+EUTGwrYWMhYoCK=3rp65gYw@mail.gmail.com>
On 06/06/2016 09:52 PM, Cong Wang wrote:
> On Mon, Jun 6, 2016 at 12:25 PM, Daniel Borkmann <daniel@iogearbox•net> wrote:
>> On 06/06/2016 07:12 PM, Cong Wang wrote:
>>>
>>> On Sat, Jun 4, 2016 at 9:24 AM, Daniel Borkmann <daniel@iogearbox•net>
>>> wrote:
>>>>
>>>> + if (n->nlmsg_type == RTM_DELTFILTER && prio == 0) {
>>>> + tcf_destroy_chain(chain);
>>>> + err = 0;
>>>> + goto errout;
>>>> + }
>>>
>>> We need to notify users we removed which filters, right?
>>
>> As far as I know, most such use cases that listen on this are bypasses
>> that mirror kernel configs from user space ... but well, sure, I can add
>> a notification if people care. Would do this as a separate patch.
>
> This is fundamental for libnl to update caches.
I see, makes sense then. Thanks!
> I don't understand why it should be separated, since notification is
> not a feature, we already have notifications in other paths.
>
>> Looking into this, I would probably make this a single notification that
>> denotes this 'wild-card' removal for that parent instead of calling
>> tfilter_notify() for each filter separately (which allocs skb, dumps it,
>> etc), qdisc del doesn't loop through it either, so probably fine this way.
>
> Makes sense.
>
> Thanks.
>
next prev parent reply other threads:[~2016-06-06 20:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 16:24 [PATCH net-next] net, cls: allow for deleting all filters for given parent Daniel Borkmann
2016-06-05 12:24 ` Jamal Hadi Salim
2016-06-05 12:53 ` Sergei Shtylyov
2016-06-05 17:47 ` Daniel Borkmann
2016-06-06 16:41 ` Sergei Shtylyov
2016-06-06 17:12 ` Cong Wang
2016-06-06 19:25 ` Daniel Borkmann
2016-06-06 19:52 ` Cong Wang
2016-06-06 20:32 ` Daniel Borkmann [this message]
2016-06-08 21:30 ` Daniel Borkmann
2016-06-09 22:54 ` Cong Wang
2016-06-10 11:49 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5755DDF0.4060503@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox