From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <xiyou.wangcong@gmail•com>,
Daniel Borkmann <daniel@iogearbox•net>
Cc: David Miller <davem@davemloft•net>,
Alexei Starovoitov <alexei.starovoitov@gmail•com>,
john fastabend <john.fastabend@gmail•com>,
Linux Kernel Network Developers <netdev@vger•kernel.org>,
Thomas Graf <tgraf@suug•ch>
Subject: Re: [PATCH net-next] net, cls: allow for deleting all filters for given parent
Date: Fri, 10 Jun 2016 07:49:41 -0400 [thread overview]
Message-ID: <575AA955.6030809@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpVga4J92BJr6_zxMwVg4M=VBeqveiTiqHG+chnk3ZD2TA@mail.gmail.com>
On 16-06-09 06:54 PM, Cong Wang wrote:
> On Wed, Jun 8, 2016 at 2:30 PM, Daniel Borkmann <daniel@iogearbox•net> wrote:
>> On 06/06/2016 09:52 PM, Cong Wang wrote:
>>>
>>> On Mon, Jun 6, 2016 at 12:25 PM, Daniel Borkmann <daniel@iogearbox•net>
>>> wrote:
>>
>> I've been playing around with both options and am actually currently
>> leaning towards the tfilter_notify() for each proto for the reason
>> that user space tc monitors can simply stay as is. F.e., if someone
>> keeps an older libnl binary that wouldn't understand such a wildcard
>> message, then elements in libnl cache won't receive updates since the
>> meta data won't match on them (average case, there probably are only
>> one up to a handful of classifiers per parent) ... hm, different topic
>> but still wondering whether libnl relying on such messages is a good
>> idea in general since under stress tfilter_notify() can also fail and
>> user space won't get the updates (except for queries with RTM_GETTFILTER).
>
> Don't worry about any failure in tfilter_notify(), we call it in
> non-wildcard removal too. Your current patch looks good to me.
>
> Thanks!
>
Daniel, I acked this already (sorry I missed the event notification
bits).
Acked-by: Jamal Hadi Salim <jhs@mojatatu•com>
cheers,
jamal
prev parent reply other threads:[~2016-06-10 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 16:24 [PATCH net-next] net, cls: allow for deleting all filters for given parent Daniel Borkmann
2016-06-05 12:24 ` Jamal Hadi Salim
2016-06-05 12:53 ` Sergei Shtylyov
2016-06-05 17:47 ` Daniel Borkmann
2016-06-06 16:41 ` Sergei Shtylyov
2016-06-06 17:12 ` Cong Wang
2016-06-06 19:25 ` Daniel Borkmann
2016-06-06 19:52 ` Cong Wang
2016-06-06 20:32 ` Daniel Borkmann
2016-06-08 21:30 ` Daniel Borkmann
2016-06-09 22:54 ` Cong Wang
2016-06-10 11:49 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575AA955.6030809@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox